[GitHub] [airflow] ashb commented on a change in pull request #10960: Fix case of Python.

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #10960:
URL: https://github.com/apache/airflow/pull/10960#discussion_r527735344



##########
File path: airflow/utils/cli_action_loggers.py
##########
@@ -18,7 +18,7 @@
 #
 """
 An Action Logger module. Singleton pattern has been applied into this module
-so that registered callbacks can be used all through the same python process.
+so that registered callbacks can be used all through the same Python process.

Review comment:
       (Strictly speaking this is correct lowercase -- it's talking about the executable)

##########
File path: airflow/utils/timezone.py
##########
@@ -112,7 +112,7 @@ def make_aware(value, timezone=None):
         raise ValueError(
             "make_aware expects a naive datetime, got %s" % value)
     if hasattr(value, 'fold'):
-        # In case of python 3.6 we want to do the same that pendulum does for python3.5
+        # In case of Python 3.6 we want to do the same that pendulum does for python3.5

Review comment:
       Missed `python3.5`. 

##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -320,7 +320,7 @@ function build_images::print_build_info() {
 }
 
 function build_images::get_docker_image_names() {
-    # python image version to use
+    # Python image version to use

Review comment:
       Ditto -- is talking about `python:3.7` etc.

##########
File path: scripts/ci/images/ci_prepare_ci_image_on_ci.sh
##########
@@ -37,7 +37,7 @@ function build_ci_image_on_ci() {
         if [[ ${GITHUB_REGISTRY_PUSH_IMAGE_TAG} != "latest" ]]; then
             python_tag_suffix="-${GITHUB_REGISTRY_PULL_IMAGE_TAG}"
         fi
-        # first we pull base python image. We will need it to re-push it after master build
+        # first we pull base Python image. We will need it to re-push it after master build

Review comment:
       Ones like this are referring to `docker pull python` - so not sure it makes sense here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org