Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]

["xi-db (via GitHub)" <gi...@apache.org>]

xi-db commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2071390477


##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -353,4 +353,20 @@ object Connect {
       .internal()
       .timeConf(TimeUnit.MINUTES)
       .createWithDefault(15)
+
+  val CONNECT_SESSION_CONNECT_MODEL_MAX_SIZE =
+    buildConf("spark.connect.session.connectML.model.maxSize")
+      .doc("Maximum size of the SparkML model. The size is in bytes.")

Review Comment:
   nit: "the SparkML model" -> "a single SparkML model"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org