You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/06/24 09:57:14 UTC
[GitHub] [lucene] uschindler opened a new pull request, #976: Exclude Lucene's own JAR files from classpath entries in Eclipse config
uschindler opened a new pull request, #976:
URL: https://github.com/apache/lucene/pull/976
This PR fixes the Eclipse task to exclude Lucene's own JAR files. I think this problem was introduced when we switched to module system, previously the project dependencies were just directories with class files, now it is lucene's JAR files.
This PR is a bit hacky, it applies regex to filename. @dweiss: If you have a better idea how to exclude project dependencies, tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #976: Exclude Lucene's own JAR files from classpath entries in Eclipse config
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165514665
I'll take a look later today, Uwe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #976: Exclude Lucene's own JAR files from classpath entries in Eclipse config
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165747736
Hi Uwe. This looks fine for me. Ideally, this should scan the dependencies and exclude project dependency artifacts (this is possible) but it adds a whole lot of code and achieves pretty much the same effect. I don't think the complexity is worth the gain here, as mentioned in the comment.
```
// This is hacky - we take the resolved compile classpath and just
// include JAR files from there. We should probably make it smarter
// by looking at real dependencies. But then: this Eclipse configuration
// doesn't really separate sources anyway so why bother.
jars += prj.configurations.compileClasspath.resolve()
jars += prj.configurations.testCompileClasspath.resolve()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler merged pull request #976: Exclude Lucene's own JAR files from classpath entries in Eclipse config
Posted by GitBox <gi...@apache.org>.
uschindler merged PR #976:
URL: https://github.com/apache/lucene/pull/976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #976: Exclude Lucene's own JAR files from classpath entries in Eclipse config
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165506350
The reason for this fix is to remove:
- compile problems (sometimes it complains about duplicate class files). This also leads to problems when some aleady compiled code does not get recompiled due to the fact that it cannot see the change (as it refers to JAR instead of Eclipse's project output). This brings strange errors.
- when you open a type it always brings multiple matches (one in JAR file and the other one in source tree). This is anoying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org