You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2008/05/23 13:17:55 UTC
[jira] Created: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
EmbedPooledConnection doesn't reset schema when creating a new logical connection
---------------------------------------------------------------------------------
Key: DERBY-3690
URL: https://issues.apache.org/jira/browse/DERBY-3690
Project: Derby
Issue Type: Bug
Components: JDBC
Affects Versions: 10.4.1.3, 10.3.1.4, 10.2.1.6, 10.1.1.0
Reporter: Knut Anders Hatlen
Priority: Minor
If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan reopened DERBY-3690:
------------------------------------
Looking at my test logs, I see that I accidentally ran the regression tests 4 times against trunk... Two of those were meant for the 10.4 branch.
I'm reopening to look at DERBY-3692. I have already verified that this checkin (r660408) caused the errors, but I do not know why yet.
Depending on the investigation, I will either fix this for 10.4 or back out the original fix.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.1.4, 10.5.0.0
>
> Attachments: derby-3690-1a-reset_schema.diff, derby-3690-1b-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan reassigned DERBY-3690:
--------------------------------------
Assignee: Kristian Waagan
I'll work this bug. I already have a fix for it as part of my patch for DERBY-3596, and after some polishing and a regression test it should be good to go.
I expect to get this done during the coming week.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-3690.
------------------------------------
Resolution: Fixed
Marking as fixed again.
A small excerpt of the latest patch (4-full_e) for DERBY-3327 was committed to the 10.4 branch and it fixed the problem seen in the J2EEDataSourceTest.
Tinderbox test for 10.4 ran cleanly.
Fix can be verified and closed.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.1.4, 10.5.0.0
>
> Attachments: derby-3690-1a-reset_schema.diff, derby-3690-1b-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3690:
-----------------------------------
Derby Info: [Patch Available]
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3690-1a-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3690:
-----------------------------------
Attachment: derby-3690-1b-reset_schema.diff
'derby-3690-1b-reset_schema.diff' is identical to 1a, except for three additions to comments to link to this Jira issue.
Regression tests have been run without failures (Sun JDK 1.6.0, Solaris 10).
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3690-1a-reset_schema.diff, derby-3690-1b-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599842#action_12599842 ]
Knut Anders Hatlen commented on DERBY-3690:
-------------------------------------------
The test cases and the fix look good to me. +1 to commit if the regression tests pass.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3690-1a-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-3690:
--------------------------------------
Attachment: PooledSchema.java
Attached is a repro that shows the problem. It prints the following when you run it:
Current schema (expect ABC): ABC
Current schema (expect DEF): DEF
Current schema (expect ABC): DEF
The last line should say ABC.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Priority: Minor
> Attachments: PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-3690.
-------------------------------------
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3690-1a-reset_schema.diff, derby-3690-1b-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-3690.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
10.4.1.4
Derby Info: (was: [Patch Available])
Committed 'derby-3690-1b-reset_schema.diff' to trunk with revision 660404 and backported it to 10.4 with revision 660408.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.1.4, 10.5.0.0
>
> Attachments: derby-3690-1a-reset_schema.diff, derby-3690-1b-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3690:
-----------------------------------
Attachment: derby-3690-1a-reset_schema.diff
'derby-3690-1a-reset_schema.diff' resets the schema in GenericLanguageConnectionContext.resetFromPool(), adds method JDBC.assertCurrentSchema and adds two regression tests.
Only one of the regression tests failed before the fix.
The repro runs successfully with the patch applied.
I'm running the full regression tests.
Patch ready for review.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3690-1a-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3690) EmbedPooledConnection doesn't reset
schema when creating a new logical connection
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603910#action_12603910 ]
Kristian Waagan commented on DERBY-3690:
----------------------------------------
Removed an unwarranted assert in 10.4 with revision 666164.
This is a manual backport of revision 662911.
> EmbedPooledConnection doesn't reset schema when creating a new logical connection
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3690
> URL: https://issues.apache.org/jira/browse/DERBY-3690
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.1.1.0, 10.2.1.6, 10.3.1.4, 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.1.4, 10.5.0.0
>
> Attachments: derby-3690-1a-reset_schema.diff, derby-3690-1b-reset_schema.diff, PooledSchema.java
>
>
> If you set the schema on a logical connection obtained from EmbedPooledConnection, that schema will also be the current schema for subsequent logical connections obtained from the same EmbedPooledConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.