[GitHub] [camel] omarsmak commented on pull request #5263: CAMEL-16060 camel-kafka - decouple kafka.PARTITION_KEY from kafka.KEY

[GitBox <gi...@apache.org>]

omarsmak commented on pull request #5263:
URL: https://github.com/apache/camel/pull/5263#issuecomment-806788723


   > Hi @omarsmak,
   > I wasn't able to execute the KafkaProducerFullTest for some reason with docker. Haven't had time to look into this. Is there anything special to consider? I checked the test quickly, it appears it already executes some calls without key (but with partition_key).
   > 
   > AFAIK the documentation does not cover the fact that both headers are required to define the partition (today). That confused me at first and I checked the code to find that out.
   
   Here is a snippet for the falling tests https://sharetext.me/raw/xq55wisjrn. Would be great if you can take a look at that to see why is that failing as these FullTests of camel-kafka are very important and they need to pass with no issues.
   
   in regards to the documentation, it is actually mentioned there: https://github.com/apache/camel/blob/master/components/camel-kafka/src/main/docs/kafka-component.adoc#producer-headers 
   
   ```
   Explicitly specify the partition (only used if the KafkaConstants.KEY header is defined)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org