You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/10/06 17:23:16 UTC

[GitHub] [systemds] mtfs20 commented on a change in pull request #1406: [SYSTEMDS-2836] Extended Update In-Place Framework

mtfs20 commented on a change in pull request #1406:
URL: https://github.com/apache/systemds/pull/1406#discussion_r723522974



##########
File path: src/main/java/org/apache/sysds/lops/Unary.java
##########
@@ -122,7 +122,12 @@ private String getOpcode() {
 	}
 	
 	public static boolean isMultiThreadedOp(OpOp1 op) {
-		return op==OpOp1.CUMSUM
+		if(op == OpOp1.INVERSE || op == OpOp1.CHOLESKY || op == OpOp1.DETECTSCHEMA)

Review comment:
       All Unary Ops are multithreaded (except Cholesky and Inverse). Therefore, we had to add the other operators so that they can be compiled with the in-place flag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org