You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/11 19:45:25 UTC

[jira] [Commented] (FLINK-3126) Remove accumulator type from "value" in web frontend

    [ https://issues.apache.org/jira/browse/FLINK-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235575#comment-15235575 ] 

ASF GitHub Bot commented on FLINK-3126:
---------------------------------------

GitHub user ZackPierce opened a pull request:

    https://github.com/apache/flink/pull/1868

    FLINK-3126 : Remove accumulator type from "value" in web frontend

    The `value` field in `StringifiedAccumulatorResult` populated by `stringifyAccumulatorResults` previously was filled by the result of calling `toString()` on an `Accumulator`.  This result, exposed via the web interface, had the unfortunate effect of showing users the innards of a given Accumulator's field values and type info rather than the target value of interest tracked by the accumulator.
    
    Thus, this PR introduces the use of `Accumulator#getLocalValue()` for the `value` field set via `StringifiedAccumulatorResult#stringifyAccumulatorResults`
    
    In keeping with the extant pattern in the class, a String value of `"null"` is used when either the `Accumulator` or the result of `getLocalValue()` is `null`.
    
    Tests have been added to verify this behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ZackPierce/flink FLINK-3126

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1868.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1868
    
----
commit 2d0eab3801a9d09ac15ed356671f3248cc8881a7
Author: Zack Pierce <zp...@newrelic.com>
Date:   2016-04-11T17:17:34Z

    FLINK-3126 : Remove accumulator type from "value" in web frontend

----


> Remove accumulator type from "value" in web frontend
> ----------------------------------------------------
>
>                 Key: FLINK-3126
>                 URL: https://issues.apache.org/jira/browse/FLINK-3126
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>            Reporter: Robert Metzger
>
> The web frontend shows the type of the counter twice:
> http://i.imgur.com/yBWT8GR.png
> It would be nicer to just show the value "42" instead of "LongValue 42" there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)