You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2017/12/20 08:53:44 UTC

[GitHub] rymanluk commented on a change in pull request #689: Feature/sensor cfg

rymanluk commented on a change in pull request #689: Feature/sensor cfg
URL: https://github.com/apache/mynewt-core/pull/689#discussion_r157964546
 
 

 ##########
 File path: hw/sensor/include/sensor/sensor.h
 ##########
 @@ -326,6 +336,7 @@ typedef int (*sensor_set_trigger_thresh_t)(struct sensor *, sensor_type_t,
 struct sensor_driver {
     sensor_read_func_t sd_read;
     sensor_get_config_func_t sd_get_config;
+    sensor_config_func_t sd_config;
 
 Review comment:
   Since we have sensor_get_config_func_t I suggest to name the new one sensor_set_config_func_t
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services