You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Mohit Arora (Jira)" <ji...@apache.org> on 2019/12/02 08:38:00 UTC
[jira] [Comment Edited] (SLING-8869)
SimpleHttpDistributionTransport does not refresh the secret for token based
implementations.
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985903#comment-16985903 ]
Mohit Arora edited comment on SLING-8869 at 12/2/19 8:37 AM:
-------------------------------------------------------------
Attached a sample patch to resolve the issue.
cc - [~ashishc]
was (Author: mohiaror):
Attached a sample patch to resolve the issue.
cc - [~ashishc]
> SimpleHttpDistributionTransport does not refresh the secret for token based implementations.
> --------------------------------------------------------------------------------------------
>
> Key: SLING-8869
> URL: https://issues.apache.org/jira/browse/SLING-8869
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
> Reporter: Mohit Arora
> Priority: Major
> Fix For: Content Distribution Core 0.4.2
>
> Attachments: SLING-8869.patch
>
>
> While saving the \{{contextKeyExecutor}} in \{{DistributionTransportContext}} map, it is not expected that the secret associated with the executor could be expired. This can happen in case of access token based implementations where the token is expired after a certain period of time and has to be refreshed.
> The code to refresh the token is written in the secret provider but since the executor is [cached in the map|[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/transport/impl/SimpleHttpDistributionTransport.java#L208]] the secrets are not refreshed. It works fine for credentials based secret provider but not for access token based.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)