You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/11 01:50:08 UTC
[GitHub] [hive] dengzhhu653 opened a new pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
dengzhhu653 opened a new pull request #3017:
URL: https://github.com/apache/hive/pull/3017
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 merged pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
dengzhhu653 merged pull request #3017:
URL: https://github.com/apache/hive/pull/3017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3017:
URL: https://github.com/apache/hive/pull/3017#discussion_r821597344
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -287,29 +287,7 @@ PartitionExpressionProxy getExpressionProxy() {
return expressionProxy;
}
- /**
- * Use {@link #getThreadId()} instead.
- * @return thread id
- */
- @Deprecated
- public static Integer get() {
- return HMSHandlerContext.getThreadId();
- }
-
- @Override
- public int getThreadId() {
- return HMSHandlerContext.getThreadId();
- }
-
- public HMSHandler(String name) throws MetaException {
- this(name, MetastoreConf.newMetastoreConf(), true);
- }
-
- public HMSHandler(String name, Configuration conf) throws MetaException {
- this(name, conf, true);
- }
-
- public HMSHandler(String name, Configuration conf, boolean init) throws MetaException {
Review comment:
Sorry @dengzhhu653, I was distracted by other tasks.
This makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #3017:
URL: https://github.com/apache/hive/pull/3017#issuecomment-1049933712
cc: @klcopp, we are removing ThreadId as it is only used for logging purposes, which should be done by the correct log4j configuration (as it is done on our clusters)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary edited a comment on pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
pvary edited a comment on pull request #3017:
URL: https://github.com/apache/hive/pull/3017#issuecomment-1049933712
cc: @klcopp, we are removing ThreadId as it is only used for logging purposes, which should be done by the correct log4j configuration (as it is done on our clusters). Could you please review this PR when you have some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3017:
URL: https://github.com/apache/hive/pull/3017#discussion_r814427240
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -287,29 +287,7 @@ PartitionExpressionProxy getExpressionProxy() {
return expressionProxy;
}
- /**
- * Use {@link #getThreadId()} instead.
- * @return thread id
- */
- @Deprecated
- public static Integer get() {
- return HMSHandlerContext.getThreadId();
- }
-
- @Override
- public int getThreadId() {
- return HMSHandlerContext.getThreadId();
- }
-
- public HMSHandler(String name) throws MetaException {
- this(name, MetastoreConf.newMetastoreConf(), true);
- }
-
- public HMSHandler(String name, Configuration conf) throws MetaException {
- this(name, conf, true);
- }
-
- public HMSHandler(String name, Configuration conf, boolean init) throws MetaException {
Review comment:
In our production(standalone or embeded metastore), the `init` is always set to false:
standalone: main -> https://github.com/apache/hive/blob/4909ba369cc331a1b490e23b73cbb2cb43f29bd9/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L314 -> https://github.com/apache/hive/blob/4909ba369cc331a1b490e23b73cbb2cb43f29bd9/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L370
embeded: https://github.com/apache/hive/blob/4909ba369cc331a1b490e23b73cbb2cb43f29bd9/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L118-L134
then we init the handler in RetryingHMSHandler,
https://github.com/apache/hive/blob/4909ba369cc331a1b490e23b73cbb2cb43f29bd9/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java#L80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
klcopp commented on pull request #3017:
URL: https://github.com/apache/hive/pull/3017#issuecomment-1050957427
LGTM. Compaction does log/store the thread ids, but it gets those directly from Thread#getId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3017:
URL: https://github.com/apache/hive/pull/3017#discussion_r814429471
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -287,29 +287,7 @@ PartitionExpressionProxy getExpressionProxy() {
return expressionProxy;
}
- /**
- * Use {@link #getThreadId()} instead.
- * @return thread id
- */
- @Deprecated
- public static Integer get() {
- return HMSHandlerContext.getThreadId();
- }
-
- @Override
- public int getThreadId() {
- return HMSHandlerContext.getThreadId();
- }
-
- public HMSHandler(String name) throws MetaException {
- this(name, MetastoreConf.newMetastoreConf(), true);
- }
-
- public HMSHandler(String name, Configuration conf) throws MetaException {
- this(name, conf, true);
- }
-
- public HMSHandler(String name, Configuration conf, boolean init) throws MetaException {
Review comment:
The `init` is true only in our tests, so I propose to remove the parameter `init` here, so that we follow the same style, i.e, the handler can not be used until after the method `init` has been called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3017:
URL: https://github.com/apache/hive/pull/3017#discussion_r821265051
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -287,29 +287,7 @@ PartitionExpressionProxy getExpressionProxy() {
return expressionProxy;
}
- /**
- * Use {@link #getThreadId()} instead.
- * @return thread id
- */
- @Deprecated
- public static Integer get() {
- return HMSHandlerContext.getThreadId();
- }
-
- @Override
- public int getThreadId() {
- return HMSHandlerContext.getThreadId();
- }
-
- public HMSHandler(String name) throws MetaException {
- this(name, MetastoreConf.newMetastoreConf(), true);
- }
-
- public HMSHandler(String name, Configuration conf) throws MetaException {
- this(name, conf, true);
- }
-
- public HMSHandler(String name, Configuration conf, boolean init) throws MetaException {
Review comment:
Hi @pvary, cloud that make sense, what do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #3017:
URL: https://github.com/apache/hive/pull/3017#issuecomment-1049880226
Hi @pvary, would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3017: HIVE-25896: Remove getThreadId from IHMSHandler
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3017:
URL: https://github.com/apache/hive/pull/3017#discussion_r813950053
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -287,29 +287,7 @@ PartitionExpressionProxy getExpressionProxy() {
return expressionProxy;
}
- /**
- * Use {@link #getThreadId()} instead.
- * @return thread id
- */
- @Deprecated
- public static Integer get() {
- return HMSHandlerContext.getThreadId();
- }
-
- @Override
- public int getThreadId() {
- return HMSHandlerContext.getThreadId();
- }
-
- public HMSHandler(String name) throws MetaException {
- this(name, MetastoreConf.newMetastoreConf(), true);
- }
-
- public HMSHandler(String name, Configuration conf) throws MetaException {
- this(name, conf, true);
- }
-
- public HMSHandler(String name, Configuration conf, boolean init) throws MetaException {
Review comment:
I am not sure about this change. Why did we remove these methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org