You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/09 11:08:47 UTC

[GitHub] tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor

tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r246336643
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java
 ##########
 @@ -254,6 +264,9 @@ private void handleRpcInvocation(RpcInvocation rpcInvocation) {
 						return;
 					}
 
+					boolean remoteSender = isRemoteSender();
+					final Method method = rpcMethod;
 
 Review comment:
   I think we only need to keep the method name instead of the whole `Method` object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services