[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #18390: [fix][broker] fix bug caused by optimistic locking

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #18390:
URL: https://github.com/apache/pulsar/pull/18390#discussion_r1016592154


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentLongLongPairHashMap.java:
##########
@@ -327,10 +330,19 @@ LongPair get(long key1, long key2, int keyHash) {
             try {
                 while (true) {
                     // First try optimistic locking
-                    long storedKey1 = table[bucket];
-                    long storedKey2 = table[bucket + 1];
-                    long storedValue1 = table[bucket + 2];
-                    long storedValue2 = table[bucket + 3];
+                    long storedKey1 = 0;
+                    long storedKey2 = 0;
+                    long storedValue1 = 0;
+                    long storedValue2 = 0;
+                    try {
+                        storedKey1 = table[bucket];
+                        storedKey2 = table[bucket + 1];
+                        storedValue1 = table[bucket + 2];
+                        storedValue2 = table[bucket + 3];
+                    } catch (ArrayIndexOutOfBoundsException e) {
+                        // read a dirty capacity, cause ArrayIndexOutOfBoundsException
+                        logger.error("Read a dirty capacity, fallback to Pessimistic Read. capacity:{}, bucket:{}", capacity, bucket);
+                    }

Review Comment:
   It's better to check index range instead of catching `ArrayIndexOutOfBoundsException`. Also, it's better not to add a log in this util class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org