[jira] [Comment Edited] (BIGTOP-1634) Puppet class parameter and hiera conversion

["jay vyas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296919#comment-14296919 ] 

jay vyas edited comment on BIGTOP-1634 at 1/29/15 2:30 PM:
-----------------------------------------------------------

[~michaelweiser] thanks! this looks like a huge improvement.    Serious reduction in puppet complexity, retaining the same logic

- in general we use the https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute workflow {{git format-patch --stdout HEAD~1..HEAD}} for contributions, to ensure you get proper accredits, but im more than happy to roll these together for you after testing it out. 
- I can test these today if nobody beats me to it.  
 


was (Author: jayunit100):
[~michaelweiser] thanks! this looks like a huge improvement.    Serious reduction in puppet complexity, retaining the same logic

- in general we use the https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute for contributions but im more than happy to roll these together for you. 
- I can test these today if nobody beats me to it.  
 

> Puppet class parameter and hiera conversion
> -------------------------------------------
>
>                 Key: BIGTOP-1634
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1634
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: backlog
>            Reporter: Michael Weiser
>              Labels: patch
>         Attachments: 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch, 0002-BIGTOP-1634-Add-enhanced-configuration.patch
>
>
> As discussed on the DEV list:
> Update the puppet code to use self-contained, parametrised classes and proper scoping. Replace all extlookup calls bei either explicit or automatic hiera parameter lookups. Implement HA/non-HA alternative via hiera lookup hierarchy. Replace append_each from bigtop_util by suffix from stdlib. Do file imports via puppet:/// scheme. Remove bigtop_util because remaining function get_settings is not needed any more.
> Additionally: Add additional configuration options for zookeeper and yarn as well as a new class for journalnode configuration.
> I've separated it into two patches of ease of review:
> 0001: actual hiera/class conversion
> 0002: functional enhancements including journalnode configuration on top of that. Mainly meant as an example for ease of further expansion and containment of changes to single modules.
> This JIRA is meant for the stuff contained in 0001, the actual hiera conversion. I can resubmit 0002 as a separate JIRA if desired. Also it should be possible to backport 0002 to the current puppet code base without much fuss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)