[GitHub] [flink] sunjincheng121 edited a comment on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

[GitBox <gi...@apache.org>]

sunjincheng121 edited a comment on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#issuecomment-494627775
 
 
   @HuangXingBo Thanks for the PR！
   I am glad to see you had listed the detail change in `Brief change log` section of PR description.
   and here is a suggestion that It's better to add the detail regarding the following things in `What is the purpose of the change` section:
   
   In this PR we want adds to submit Python Table API job in CliFrontend which mentioned in the FLIP-38.  but we do not add the UDFs section due to the UDFs are not supported yet. We will follow The current `flink` command line syntax, and add some options to support submit the Python API, the detail as follows:(just example)
   
   `flink <ACTION> [OPTIONS] [ARGUMENTS]`
   
   On the basis of the current `run` ACTION, we add to Python Table API support, specific OPTIONS are as follows:
   - py --python  <python-file-name>
     Python script with the program entry point. We can configure dependent resources with the `--py-files` option.
   
   - pyfs --py-files <python-files>   
   ...
   ...
   
   Also add the usage examples such as:
   
   - Submit a simple job without any dependencies and parameters
   `FLINK_HOME/bin/flink run -py example.py`
   - Submit a job with dependencies and parallelism 16
   `FLINK_HOME/bin/flink run -p 16 -py example.py -pyfs resources1.egg, resources2.zip, resource3.py`
   ....
   
   Then for this detail description and the detail change info, you have listed in `Brief change log` section, the reviewer can have a very clear impression. :)
   What do you think ? :)
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services