You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/05/03 08:25:46 UTC
[GitHub] [camel] orpiske opened a new pull request, #9984: CAMEL-19058: wrap some internal properties in an EnumMap
orpiske opened a new pull request, #9984:
URL: https://github.com/apache/camel/pull/9984
This should make it simpler to abstract their complexity while maintaining reasonable performance (as they are used in many parts within the hot path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9984:
URL: https://github.com/apache/camel/pull/9984#issuecomment-1532635800
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9984:
URL: https://github.com/apache/camel/pull/9984#issuecomment-1532713032
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #9984:
URL: https://github.com/apache/camel/pull/9984#issuecomment-1532636301
This is the alternative implementation for #9982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #9984:
URL: https://github.com/apache/camel/pull/9984#discussion_r1183386709
##########
core/camel-support/src/main/java/org/apache/camel/support/AbstractExchange.java:
##########
@@ -385,7 +372,7 @@ public boolean removeProperties(String pattern, String... excludePatterns) {
continue;
}
matches = true;
- internalProperties[epk.ordinal()] = null;
+ internalProperties.put(epk, null);
Review Comment:
Maybe we can use the `remove` method here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #9984:
URL: https://github.com/apache/camel/pull/9984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9984:
URL: https://github.com/apache/camel/pull/9984#issuecomment-1532657869
Yeah JDK classes are good to prefer to use when they fit the purpose - map optimized internally with quick object array, and lookup by ordinal fixed number (like the old code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9984: CAMEL-19058: wrap some internal properties in an EnumMap
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9984:
URL: https://github.com/apache/camel/pull/9984#issuecomment-1532713119
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org