You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Billie Rinaldi <bi...@apache.org> on 2015/05/21 04:16:18 UTC
Review Request 34523: AMBARI-10420 Configure Accumulo in the HA wizard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Repository: ambari
Description
-------
AMBARI-10420 Configure Accumulo in the HA wizard
Diffs
-----
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
ambari-web/app/controllers/wizard/step7_controller.js f0ae1d3
ambari-web/app/data/HDP2/ha_properties.js 63daf49
ambari-web/app/messages.js d0f680f
Diff: https://reviews.apache.org/r/34523/diff/
Testing
-------
Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
Thanks,
Billie Rinaldi
Re: Review Request 34523: AMBARI-10420 Configure Accumulo in the HA
wizard
Posted by Billie Rinaldi <bi...@apache.org>.
> On May 21, 2015, 3:03 a.m., Jaimin Jetly wrote:
> > ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js, line 244
> > <https://reviews.apache.org/r/34523/diff/1/?file=966016#file966016line244>
> >
> > Remove the logging message
All of the functions in rollback_controller.js have this console.warn as their first line.
- Billie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/#review84654
-----------------------------------------------------------
On May 21, 2015, 2:16 a.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34523/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 2:16 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10420 Configure Accumulo in the HA wizard
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
> ambari-web/app/controllers/wizard/step7_controller.js f0ae1d3
> ambari-web/app/data/HDP2/ha_properties.js 63daf49
> ambari-web/app/messages.js d0f680f
>
> Diff: https://reviews.apache.org/r/34523/diff/
>
>
> Testing
> -------
>
> Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 34523: AMBARI-10420 Configure Accumulo in the HA
wizard
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/#review84654
-----------------------------------------------------------
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js
<https://reviews.apache.org/r/34523/#comment136004>
Remove the logging message
- Jaimin Jetly
On May 21, 2015, 2:16 a.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34523/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 2:16 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10420 Configure Accumulo in the HA wizard
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
> ambari-web/app/controllers/wizard/step7_controller.js f0ae1d3
> ambari-web/app/data/HDP2/ha_properties.js 63daf49
> ambari-web/app/messages.js d0f680f
>
> Diff: https://reviews.apache.org/r/34523/diff/
>
>
> Testing
> -------
>
> Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 34523: AMBARI-10420 Configure Accumulo in the HA
wizard
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/
-----------------------------------------------------------
(Updated May 21, 2015, 11:28 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Changes
-------
Fixed splice bug
Repository: ambari
Description
-------
AMBARI-10420 Configure Accumulo in the HA wizard
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
ambari-web/app/controllers/wizard/step7_controller.js 3f3cafb
ambari-web/app/data/HDP2/ha_properties.js 63daf49
ambari-web/app/messages.js d0f680f
Diff: https://reviews.apache.org/r/34523/diff/
Testing
-------
Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
Thanks,
Billie Rinaldi
Re: Review Request 34523: AMBARI-10420 Configure Accumulo in the HA
wizard
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/
-----------------------------------------------------------
(Updated May 21, 2015, 5:38 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Repository: ambari
Description
-------
AMBARI-10420 Configure Accumulo in the HA wizard
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
ambari-web/app/controllers/wizard/step7_controller.js 3f3cafb
ambari-web/app/data/HDP2/ha_properties.js 63daf49
ambari-web/app/messages.js d0f680f
Diff: https://reviews.apache.org/r/34523/diff/
Testing
-------
Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
Thanks,
Billie Rinaldi
Re: Review Request 34523: AMBARI-10420 Configure Accumulo in the HA
wizard
Posted by Billie Rinaldi <bi...@apache.org>.
> On May 21, 2015, 2:46 a.m., Jaimin Jetly wrote:
> > ambari-web/app/messages.js, line 1225
> > <https://reviews.apache.org/r/34523/diff/1/?file=966021#file966021line1225>
> >
> > This message is shown for HBase because HBase Regionserver stop command does not work if datanode is not up at that time.
> >
> > Is it the same case with Accumul ? Otherwise we dont need to change this message
Tested without stopping Accumulo.
- Billie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/#review84653
-----------------------------------------------------------
On May 21, 2015, 5:38 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34523/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 5:38 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10420 Configure Accumulo in the HA wizard
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
> ambari-web/app/controllers/wizard/step7_controller.js 3f3cafb
> ambari-web/app/data/HDP2/ha_properties.js 63daf49
> ambari-web/app/messages.js d0f680f
>
> Diff: https://reviews.apache.org/r/34523/diff/
>
>
> Testing
> -------
>
> Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 34523: AMBARI-10420 Configure Accumulo in the HA
wizard
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34523/#review84653
-----------------------------------------------------------
ambari-web/app/messages.js
<https://reviews.apache.org/r/34523/#comment136003>
This message is shown for HBase because HBase Regionserver stop command does not work if datanode is not up at that time.
Is it the same case with Accumul ? Otherwise we dont need to change this message
- Jaimin Jetly
On May 21, 2015, 2:16 a.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34523/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 2:16 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10420 Configure Accumulo in the HA wizard
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e746de7
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 193b89f
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 4a92447
> ambari-web/app/controllers/wizard/step7_controller.js f0ae1d3
> ambari-web/app/data/HDP2/ha_properties.js 63daf49
> ambari-web/app/messages.js d0f680f
>
> Diff: https://reviews.apache.org/r/34523/diff/
>
>
> Testing
> -------
>
> Tested installing and enabling HA once on 3 VMs. I made a couple of tweaks after that so I'll be testing it again.
>
>
> Thanks,
>
> Billie Rinaldi
>
>