[jira] [Commented] (GEODE-2861) remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055986#comment-16055986 ] 

ASF GitHub Bot commented on GEODE-2861:
---------------------------------------

GitHub user nreich opened a pull request:

    https://github.com/apache/geode/pull/594

    GEODE-2861: Remove dead code

      * code removed related to shutting down DiskStoreTaskPool
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nreich/geode feature/GEODE-2861

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #594
    
----
commit dfcc01b1e13379e03bb65562319d596570293055
Author: Nick Reich <nr...@pivotal.io>
Date:   2017-06-16T22:52:00Z

    GEODE-2861: Remove dead code
    
      * code removed related to shutting down DiskStoreTaskPool

----


> remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-2861
>                 URL: https://issues.apache.org/jira/browse/GEODE-2861
>             Project: Geode
>          Issue Type: Improvement
>          Components: persistence
>    Affects Versions: 1.0.0-incubating
>            Reporter: Darrel Schneider
>            Assignee: Nick Reich
>            Priority: Trivial
>              Labels: storage_3
>
> Both GemFireCacheImpl and DiskStoreImpl have deadcode related to shutting down the DiskStoreTaskPool.
> On DiskStoreImpl see these methods:
>   stopDiskStoreTaskPool
>   shutdownPool
> On GemFireCacheImpl the field diskStoreTaskPool is always null.
> Note that a bug exists in this deadcode that causes it to not call taskCancelled as it iterates over a list of runnables. Since this code is dead it is currently doing no harm but if the code is not removed then make sure and fix this loop.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)