[GitHub] greg-dove commented on issue #78: Assign to Boolean variable does not convert to true or false, breaking loose comparison with ==

[GitBox <gi...@apache.org>]

greg-dove commented on issue #78: Assign to Boolean variable does not convert to true or false, breaking loose comparison with ==
URL: https://github.com/apache/royale-compiler/issues/78#issuecomment-461614133
 
 
   fwiw I am in the 'initialise' over 'optimise' camp in general too, to maintain as3 consistency. There are still  enough other issues to deal with when porting apps, or using other code, that this type of optimization seems (to me) to be a trivial advantage. I think of the recent example with AMFBinaryData where code was working, but really should not have been (and was exposed by Josh' compiler updates for numeric type conversions) - because it was behaving like javascript and not actionscript - is a good example of why this type of thing should be on by default. Also, again fwiw, I think jx-compiler should not try to output things like **!!0** or **!0** etc here... it should be **true** or **false**. GCC does all that stuff in the release output optimisations... that's its job IMO. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services