You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2024/03/07 10:56:19 UTC

[PR] Flink 34324 [flink]

XComp opened a new pull request, #24463:
URL: https://github.com/apache/flink/pull/24463

   ## What is the purpose of the change
   
   This PR contains some refactorings of the s3-related tests. I moved the branch from my fork (see related PR #24244) to the main repo to check whether this would enable the s3 related tests without merging the PR to `master`.
   
   ## Brief change log
   
   * Fixes error message in test execution
   * unifies S3-related code in one location
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24463:
URL: https://github.com/apache/flink/pull/24463#issuecomment-1983532633

   I deleted the branch again because it doesn't enable the S3 credentials, of course. :facepalm: Anyway, it's better to replace it with Minio.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp closed pull request #24463: [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location
URL: https://github.com/apache/flink/pull/24463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24463:
URL: https://github.com/apache/flink/pull/24463#issuecomment-1983274468

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d78f0d7ea556f374bc7f9ba62953045713fe86e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2d78f0d7ea556f374bc7f9ba62953045713fe86e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d78f0d7ea556f374bc7f9ba62953045713fe86e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org