You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2022/12/21 05:38:21 UTC
[camel] branch main updated: (chores) Lasts sonar issues about replace size() > 0 by !isEmpty() (#8935)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new e10666bbd11 (chores) Lasts sonar issues about replace size() > 0 by !isEmpty() (#8935)
e10666bbd11 is described below
commit e10666bbd116782e971cc78e21d93bdb49e36b34
Author: Gilvan Filho <gi...@gmail.com>
AuthorDate: Wed Dec 21 02:38:15 2022 -0300
(chores) Lasts sonar issues about replace size() > 0 by !isEmpty() (#8935)
* (chores) camel-test: replace size() > 0 by !isEmpty()
* (chores) camel-wal: replace size() > 0 by !isEmpty()
* (chores) camel-console: replace size() > 0 by !isEmpty()
* (chores) camel-core-model: replace size() > 0 by !isEmpty()
* (chores) camel-health: replace size() > 0 by !isEmpty()
---
.../src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java | 2 +-
.../src/main/java/org/apache/camel/component/wal/LogWriter.java | 2 +-
.../java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java | 2 +-
.../src/main/java/org/apache/camel/builder/AdviceWithTasks.java | 2 +-
.../java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java b/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java
index aba28f00486..b5ffcabfd5a 100644
--- a/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java
+++ b/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java
@@ -625,7 +625,7 @@ public abstract class CamelTestSupport extends TestSupport {
builder.append("\t\tCamelContext (").append(managedCamelContext.getCamelId()).append(") total: ")
.append(contextExchangesTotal).append("\n");
- if (uncoveredRoutes.size() > 0) {
+ if (!uncoveredRoutes.isEmpty()) {
builder.append("\t\tUncovered routes: ").append(uncoveredRoutes.stream().collect(Collectors.joining(", ")))
.append("\n");
}
diff --git a/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java b/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java
index 92375ecb92d..17169dbe456 100644
--- a/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java
+++ b/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java
@@ -150,7 +150,7 @@ public final class LogWriter implements AutoCloseable {
.filter(c -> c != null && c.layerInfo.getLayer() != transactionLog.currentLayer())
.map(e -> tryPersist(layerInfo, e.logEntry)).collect(Collectors.toList());
- if (collect.size() > 0) {
+ if (!collect.isEmpty()) {
final EntryInfo lastOnLayer = collect.get(0);
LOG.trace("Current pos is: {}", fileChannel.position());
diff --git a/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java b/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java
index c84337d47cc..a3bb0e1dff8 100644
--- a/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java
+++ b/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java
@@ -179,7 +179,7 @@ public class DefaultDevConsoleRegistry extends ServiceSupport implements DevCons
DefaultDevConsolesLoader loader = new DefaultDevConsolesLoader(camelContext);
Collection<DevConsole> col = loader.loadDevConsoles();
- if (col.size() > 0) {
+ if (!col.isEmpty()) {
int added = 0;
// register the loaded consoles
for (DevConsole console : col) {
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java b/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java
index 0a42743c6f9..5c90fda4e27 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java
@@ -472,7 +472,7 @@ public final class AdviceWithTasks {
break;
}
}
- if (outputs.size() >= 1 && allAbstract) {
+ if (!outputs.isEmpty() && allAbstract) {
// if all outputs are abstract then get its last output, as
outputs = outputs.get(outputs.size() - 1).getOutputs();
}
diff --git a/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java b/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java
index 9d31fa631d3..7db8874ccc5 100644
--- a/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java
+++ b/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java
@@ -301,7 +301,7 @@ public class DefaultHealthCheckRegistry extends ServiceSupport implements Health
Collection<HealthCheck> col = loader.loadHealthChecks();
// register loaded health-checks
col.forEach(this::register);
- if (col.size() > 0) {
+ if (!col.isEmpty()) {
String time = TimeUtils.printDuration(watch.taken(), true);
LOG.debug("Health checks (scanned: {}) loaded in {}", col.size(), time);
}