Deprecate svn_fs_revision_prop() and svn_fs_txn_prop()?

[Blair Zajac <bl...@orcaware.com>]

We allow binary data to be stored in revision properties, and given that 
svn_fs_revision_prop() and svn_fs_txn_prop() return const char * data, then it's 
possible for the caller to not "see" all the data if there's a \0 in it.

So should we deprecate them?  Maybe add ...prop2() versions that use svn_string_t?

Blair

Re: Deprecate svn_fs_revision_prop() and svn_fs_txn_prop()?

[Blair Zajac <bl...@orcaware.com>]

On 11/30/10 6:20 PM, Daniel Shahaf wrote:
> Blair Zajac wrote on Tue, Nov 30, 2010 at 16:42:22 -0800:
>> We allow binary data to be stored in revision properties, and given that
>> svn_fs_revision_prop() and svn_fs_txn_prop() return const char * data,
>
> Is your svn_fs_revision_prop() different from mine?

Nevermind, I was reading it wrong.  Too long at the puter :)

Blair

Re: Deprecate svn_fs_revision_prop() and svn_fs_txn_prop()?

[Daniel Shahaf <d....@daniel.shahaf.name>]

Blair Zajac wrote on Tue, Nov 30, 2010 at 16:42:22 -0800:
> We allow binary data to be stored in revision properties, and given that  
> svn_fs_revision_prop() and svn_fs_txn_prop() return const char * data, 

Is your svn_fs_revision_prop() different from mine?

[[[
/** Set @a *value_p to the value of the property named @a propname on
 * transaction @a txn.  If @a txn has no property by that name, set
 * @a *value_p to zero.  Allocate the result in @a pool.
 */
svn_error_t *
svn_fs_txn_prop(svn_string_t **value_p,
                svn_fs_txn_t *txn,
                const char *propname,
                apr_pool_t *pool);

/** Set @a *value_p to the value of the property named @a propname on
 * revision @a rev in the filesystem @a fs.  If @a rev has no property by
 * that name, set @a *value_p to zero.  Allocate the result in @a pool.
 */
svn_error_t *
svn_fs_revision_prop(svn_string_t **value_p,
                     svn_fs_t *fs,
                     svn_revnum_t rev,
                     const char *propname,
                     apr_pool_t *pool);
]]]