[GitHub] villebro commented on issue #5686: Force quoted column aliases for Oracle-like databases

[GitBox <gi...@apache.org>]

villebro commented on issue #5686: Force quoted column aliases for Oracle-like databases
URL: https://github.com/apache/incubator-superset/pull/5686#issuecomment-417849084
 
 
   Seems like testing help isn't forthcoming, so would need to decide on whether or not to merge this. I feel confident about this PR, especially compared to the existing logic, and am ready to help iron out any potential problems with Redshift/Oracle/DB2 if such arise. So I would recommend merging. @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org