You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/25 04:00:07 UTC

[GitHub] [shardingsphere] strongduanmu commented on pull request #7573: migrate some methods in InsertStatement to InsertStatementContext

strongduanmu commented on pull request #7573:
URL: https://github.com/apache/shardingsphere/pull/7573#issuecomment-698706692


   > @strongduanmu
   > 
   > This is an excellent PR! I know you took much time and thought of it, but I supposed it was worth it, which help us improve the logic thinking for programming. Moreover, I believe you definitely have a deeper understanding of the relevant modules of ShardingSphere. So If there are any similar PRs, welcome you to be a reviewer for them!
   > 
   > Best,
   > Trista
   
   @tristaZero Thank you very much for your perfect suggestion in this PR, which greatly improved my programming thinking. I am very willing to review related changes later. 😀


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org