You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2016/05/02 13:04:01 UTC
svn commit: r1741962 - in /ofbiz/branches/release15.12: ./
applications/accounting/widget/AgreementForms.xml
Author: jleroux
Date: Mon May 2 11:04:01 2016
New Revision: 1741962
URL: http://svn.apache.org/viewvc?rev=1741962&view=rev
Log:
"Applied fix from trunk for revision: 1741960"
------------------------------------------------------------------------
r1741960 | jleroux | 2016-05-02 13:02:36 +0200 (lun. 02 mai 2016) | 17 lignes
A patch from Ingo Wolfmayr for "Agreement Search List requires partyIdFrom/partyIdTo or fails" - https://issues.apache.org/jira/browse/OFBIZ-7030
How tot test!
Create a new agreement and fill the following fields:
partyTo (for ex. DemoCustomer)
Role Type Id From (for ex. Client)
Role Type Id To(for ex. Bill-to customer)
Agreement Type ID (for ex. Sales)
Description: test
error: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]java.lang.IllegalArgumentException: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]
I create a generic agreement (from company to all customers with no specific agreements) - I could not access it after creation.
This more a workaround than a fix but it works and is better than an error message. Missing fields will be set to empty field. Service will be called and return nothing.
------------------------------------------------------------------------
Modified:
ofbiz/branches/release15.12/ (props changed)
ofbiz/branches/release15.12/applications/accounting/widget/AgreementForms.xml
Propchange: ofbiz/branches/release15.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon May 2 11:04:01 2016
@@ -9,4 +9,4 @@
/ofbiz/branches/json-integration-refactoring:1634077-1635900
/ofbiz/branches/multitenant20100310:921280-927264
/ofbiz/branches/release13.07:1547657
-/ofbiz/trunk:1722712,1723007,1723248,1724402,1724411,1724566,1724689,1724763,1724916,1724918,1724925,1724930,1724940,1724943,1724946,1724951,1724957,1724975,1724978,1725006,1725217,1725257,1725561,1725574,1726388,1726486,1726493,1726828,1728398,1728411,1729005,1729078,1729609,1729809,1730035,1730456,1730735-1730736,1730747,1730758,1730882,1730889,1731382,1731396,1732454,1732570,1732721,1733951,1733956,1734246,1734269,1734276,1734912,1734918,1735021,1735244,1735385,1735398,1735569,1735731,1735734,1735750,1735753,1735756,1735759,1735773,1736083,1736087,1736272,1736434,1736628,1736851,1736854,1736890,1737156,1737440,1738235,1738303,1738407,1738902,1739438,1739448,1739571,1740008,1740442,1740629,1741146,1741563,1741684,1741925,1741930
+/ofbiz/trunk:1722712,1723007,1723248,1724402,1724411,1724566,1724689,1724763,1724916,1724918,1724925,1724930,1724940,1724943,1724946,1724951,1724957,1724975,1724978,1725006,1725217,1725257,1725561,1725574,1726388,1726486,1726493,1726828,1728398,1728411,1729005,1729078,1729609,1729809,1730035,1730456,1730735-1730736,1730747,1730758,1730882,1730889,1731382,1731396,1732454,1732570,1732721,1733951,1733956,1734246,1734269,1734276,1734912,1734918,1735021,1735244,1735385,1735398,1735569,1735731,1735734,1735750,1735753,1735756,1735759,1735773,1736083,1736087,1736272,1736434,1736628,1736851,1736854,1736890,1737156,1737440,1738235,1738303,1738407,1738902,1739438,1739448,1739571,1740008,1740442,1740629,1741146,1741563,1741684,1741925,1741930,1741960
Modified: ofbiz/branches/release15.12/applications/accounting/widget/AgreementForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/widget/AgreementForms.xml?rev=1741962&r1=1741961&r2=1741962&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/widget/AgreementForms.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/widget/AgreementForms.xml Mon May 2 11:04:01 2016
@@ -60,15 +60,20 @@ under the License.
<field-map field-name="viewIndex" from-field="viewIndex"/>
<field-map field-name="viewSize" from-field="viewSize"/>
</service>
+
+ <!--Fallback if partyIdFrom or partyIdTo is empty, at this time it is not possible to add is-empty condition in widgets (in this case to prevent service call)-->
+ <set field="partyIdFromTmp" from-field="parameters.partyIdFrom" default-value=""/>
+ <set field="partyIdToTmp" from-field="parameters.partyIdTo" default-value=""/>
+
</actions>
<row-actions>
<service service-name="getPartyNameForDate" result-map="partyNameResultFrom">
- <field-map field-name="partyId" from-field="partyIdFrom"/>
+ <field-map field-name="partyId" from-field="partyIdFromTmp"/>
<field-map field-name="compareDate" from-field="agreementDate"/>
<field-map field-name="lastNameFirst" value="Y"/>
</service>
<service service-name="getPartyNameForDate" result-map="partyNameResultTo">
- <field-map field-name="partyId" from-field="partyIdTo"/>
+ <field-map field-name="partyId" from-field="partyIdToTmp"/>
<field-map field-name="compareDate" from-field="agreementDate"/>
<field-map field-name="lastNameFirst" value="Y"/>
</service>