You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/04 20:24:00 UTC
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
dschneider-pivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435518492
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
+- **Connection**: ECHO, TIME, SHUTDOWN
Review comment:
did you intend to mention ECHO, TIME, and SHUTDOWN twice (once in Server once in Connection)?
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
DBSIZE makes more sense to be in the "Keys" section since it tells you how many keys exist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org