[GitHub] [dubbo] AlbumenJ commented on pull request #10921: fix NPE bug of URL

[GitBox <gi...@apache.org>]

AlbumenJ commented on PR #10921:
URL: https://github.com/apache/dubbo/pull/10921#issuecomment-1313221504

   > > Let `InstanceAddressURL` override these methods would be better
   > 
   > If urlAddress is empty, does it simply return null? I think we need the necessary NPE check for the URL, which has other subclasses.
   
   In `InstanceAddressURL`, a new URL instance should be created if there are some modifications. The new URL type can be `DubboServiceAddressURL`.
   
   The case of `urlParam` is null is only happends in `InstanceAddressURL`, and override those origin method would fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org