[GitHub] [flink] xuefuz commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule to provide Hive built-in functions

[GitBox <gi...@apache.org>]

xuefuz commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule to provide Hive built-in functions
URL: https://github.com/apache/flink/pull/9988#discussion_r341750761
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java
 ##########
 @@ -335,4 +338,18 @@ public CatalogColumnStatisticsDataDate toFlinkDateColStats(ColumnStatisticsData
 			throw new CatalogException("Failed to get table schema from deserializer", e);
 		}
 	}
+
+	@Override
+	public Set<String> listBuiltInFunctions() {
+		// FunctionInfo doesn't have isBuiltIn() API to tell whether it's a builtin function or not
+		// prior to Hive 1.2.0
+		throw new UnsupportedOperationException("Listing built in functions are not supported until Hive 1.2.0");
+	}
+
+	@Override
+	public Optional<FunctionInfo> getBuiltInFunctionInfo(String name) {
+		// FunctionInfo doesn't have isBuiltIn() API to tell whether it's a builtin function or not
+		// prior to Hive 1.2.0
+		throw new UnsupportedOperationException("Getting built in functions are not supported until Hive 1.2.0");
+	}
 
 Review comment:
   I think we have two options: 1. Document the restriction (with a JIRA to track) 2. Just list all functions which might include non-built-in ones. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services