You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2013/03/12 09:16:20 UTC
Review Request: Feature Syslog Enhancements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/
-----------------------------------------------------------
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
Description
-------
This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value=""/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
Note: I have not added one conflicting file with SNMP feature https://reviews.apache.org/r/9870/ . I will update the patch once that will be merged in master.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
Diffs
-----
client/pom.xml cda6ab8
plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
Diff: https://reviews.apache.org/r/9870/diff/
Testing
-------
Units tests for functionality are written and manual testing for syslog message generation for few alerts
Thanks,
Anshul Gangwar
Re: Review Request: Feature Syslog Enhancements
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/#review18417
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On March 19, 2013, 10:52 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9870/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 10:52 a.m.)
>
>
> Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
> <appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SyslogHosts" value=""/>
> <param name="Facility" value="LOCAL6"/>
> <layout class="org.apache.log4j.PatternLayout">
> <param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
> </layout>
> </appender>
>
> To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
>
> <appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
> <param name="Facility" value="LOCAL6"/>
> <layout class="org.apache.log4j.PatternLayout">
> <param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
> </layout>
> </appender>
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
>
>
> Diffs
> -----
>
> client/pom.xml ecf232b
> client/tomcatconf/log4j-cloud.xml.in ce4079f
> plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
> plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
> plugins/pom.xml 5d31a72
>
> Diff: https://reviews.apache.org/r/9870/diff/
>
>
> Testing
> -------
>
> Units tests for functionality are written and manual testing for syslog message generation for few alerts
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature Syslog Enhancements
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/#review18502
-----------------------------------------------------------
Ship it!
Branch: refs/heads/master
Commit: 6a7156ad9af6ca173c0b685d69d5724d91d0a401
Parents: 2c176ab
Author: Anshul Gangwar <an...@citrix.com>
Authored: Wed Mar 6 14:11:47 2013 +0530
Committer: Sateesh Chodapuneedi <sa...@apache.org>
Committed: Fri Mar 29 09:53:05 2013 +0530
- Sateesh Chodapuneedi
On March 29, 2013, 9:50 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9870/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 9:50 a.m.)
>
>
> Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
> <appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SyslogHosts" value=""/>
> <param name="Facility" value="LOCAL6"/>
> <layout class="org.apache.log4j.PatternLayout">
> <param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
> </layout>
> </appender>
>
> To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
>
> <appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
> <param name="Facility" value="LOCAL6"/>
> <layout class="org.apache.log4j.PatternLayout">
> <param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
> </layout>
> </appender>
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
>
>
> Diffs
> -----
>
> client/pom.xml 23892e1
> client/tomcatconf/log4j-cloud.xml.in ce4079f
> plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
> plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
> plugins/pom.xml 39d9907
>
> Diff: https://reviews.apache.org/r/9870/diff/
>
>
> Testing
> -------
>
> Units tests for functionality are written and manual testing for syslog message generation for few alerts
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature Syslog Enhancements
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/
-----------------------------------------------------------
(Updated March 29, 2013, 9:50 a.m.)
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
Changes
-------
rebased with current master
Description
-------
This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value=""/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
Diffs (updated)
-----
client/pom.xml 23892e1
client/tomcatconf/log4j-cloud.xml.in ce4079f
plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
plugins/pom.xml 39d9907
Diff: https://reviews.apache.org/r/9870/diff/
Testing
-------
Units tests for functionality are written and manual testing for syslog message generation for few alerts
Thanks,
Anshul Gangwar
Re: Review Request: Feature Syslog Enhancements
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/
-----------------------------------------------------------
(Updated March 19, 2013, 10:52 a.m.)
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
Description (updated)
-------
This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value=""/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
Diffs
-----
client/pom.xml ecf232b
client/tomcatconf/log4j-cloud.xml.in ce4079f
plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
plugins/pom.xml 5d31a72
Diff: https://reviews.apache.org/r/9870/diff/
Testing
-------
Units tests for functionality are written and manual testing for syslog message generation for few alerts
Thanks,
Anshul Gangwar
Re: Review Request: Feature Syslog Enhancements
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/
-----------------------------------------------------------
(Updated March 19, 2013, 6:23 a.m.)
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
Changes
-------
added the remaining file , rebased it to latest master and squashed the changes in one commit
Description
-------
This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value=""/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
Note: I have not added one conflicting file with SNMP feature https://reviews.apache.org/r/9870/ . I will update the patch once that will be merged in master.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
Diffs (updated)
-----
client/pom.xml ecf232b
client/tomcatconf/log4j-cloud.xml.in ce4079f
plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
plugins/pom.xml 5d31a72
Diff: https://reviews.apache.org/r/9870/diff/
Testing
-------
Units tests for functionality are written and manual testing for syslog message generation for few alerts
Thanks,
Anshul Gangwar
Re: Review Request: Feature Syslog Enhancements
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/
-----------------------------------------------------------
(Updated March 15, 2013, 10:35 a.m.)
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
Changes
-------
updated the patch and squashed the changes in one commit
Description
-------
This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value=""/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by ,
<appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
<param name="Threshold" value="WARN"/>
<param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/>
<param name="Facility" value="LOCAL6"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/>
</layout>
</appender>
Note: I have not added one conflicting file with SNMP feature https://reviews.apache.org/r/9870/ . I will update the patch once that will be merged in master.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
Diffs (updated)
-----
client/pom.xml cda6ab8
plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION
plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
Diff: https://reviews.apache.org/r/9870/diff/
Testing
-------
Units tests for functionality are written and manual testing for syslog message generation for few alerts
Thanks,
Anshul Gangwar