[GitHub] [hadoop] adoroszlai opened a new pull request #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler
URL: https://github.com/apache/hadoop/pull/1283
 
 
   ## What changes were proposed in this pull request?
   
   Including `proxy` in the trace message causes stack overflow, since it results in a call to `proxy.toString()`, which also wants to log, etc.
   
   I would also argue that `target` is more interesting for logging than `proxy`: eg. `org.apache.hadoop.ozone.client.rpc.RpcClient@5c3d4f05` vs. `com.sun.proxy.$Proxy87`.
   
   https://issues.apache.org/jira/browse/HDDS-1954
   
   ## How was this patch tested?
   
   Set root log level to TRACE and ran some integration tests via Maven (eg. `TestOzoneRpcClientWithRatis`).  Verified that `surefire-reports` has no `StackOverflowError`, but has messages like:
   
   ```
   TRACE client.OzoneClient (OzoneClientInvocationHandler.java:invoke(51)) - Invoking method public abstract org.apache.hadoop.ozone.client.OzoneVolume org.apache.hadoop.ozone.client.protocol.ClientProtocol.getVolumeDetails(java.lang.String) throws java.io.IOException on target org.apache.hadoop.ozone.client.rpc.RpcClient@5c3d4f05
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org