You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2008/05/26 07:07:55 UTC

[jira] Created: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?
----------------------------------------------------------------------

                 Key: MAHOUT-58
                 URL: https://issues.apache.org/jira/browse/MAHOUT-58
             Project: Mahout
          Issue Type: Improvement
            Reporter: Sean Owen


HI all, just looking at the deprecation warnings I am seeing when compiling. Looks like we've deprecated DistanceMeasure.distance(Float[], Float[]). Looks like it is easy to just remove this altogether, and with it, AbstractDistanceMeasure. OK to do?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by Grant Ingersoll <gs...@apache.org>.
On May 26, 2008, at 4:07 AM, Karl Wettin (JIRA) wrote:

>
>    [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599781 
> #action_12599781 ]
>
> Karl Wettin commented on MAHOUT-58:
> -----------------------------------
>
> The reason for AbstractDistanceMeasure was introduced was to handle  
> backwards compatibility of the depricated method. Actually, it  
> demonstrates one of many reasons to why abstract classes often are  
> preferred instead of interfaces when possible.
>

We don't really need to worry about back compatibility when there is  
nothing to be back compatible to.  Taste is probably the only thing  
that need worry about deprecating at this point.

-Grant

[jira] Commented: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599781#action_12599781 ] 

Karl Wettin commented on MAHOUT-58:
-----------------------------------

The reason for AbstractDistanceMeasure was introduced was to handle backwards compatibility of the depricated method. Actually, it demonstrates one of many reasons to why abstract classes often are preferred instead of interfaces when possible.

While we are at the subject, I'm not sure I like the separation of weighted and non weighed distance measurements. I only have my self to blame.. :)


> Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-58
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-58
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Sean Owen
>
> HI all, just looking at the deprecation warnings I am seeing when compiling. Looks like we've deprecated DistanceMeasure.distance(Float[], Float[]). Looks like it is easy to just remove this altogether, and with it, AbstractDistanceMeasure. OK to do?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Wettin updated MAHOUT-58:
------------------------------

    Fix Version/s: 0.1

> Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-58
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-58
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Sean Owen
>             Fix For: 0.1
>
>
> HI all, just looking at the deprecation warnings I am seeing when compiling. Looks like we've deprecated DistanceMeasure.distance(Float[], Float[]). Looks like it is easy to just remove this altogether, and with it, AbstractDistanceMeasure. OK to do?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by Grant Ingersoll <gs...@apache.org>.
On May 26, 2008, at 12:37 PM, Sean Owen (JIRA) wrote:

>
>    [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599871 
> #action_12599871 ]
>
> Sean Owen commented on MAHOUT-58:
> ---------------------------------
>
> Grant said: "We don't really need to worry about back compatibility  
> when there is nothing to be back compatible to.  Taste is probably  
> the only thing that need worry about deprecating at this point."
>
> Yeah that was my view. I assume that with no public releases we can  
> freely change stuff like this. I am not bothered by the warnings  
> really just helpfully suggesting I have a changelist ready to clear  
> this out if there are no objections.

+1.

>
>
> On Taste, erm what should be deprecated? I already took the  
> opportunity to remove anything that was deprecated, and remove more  
> stuff that is kind of old and unused. I consider this a "2.0"  
> release and not necessarily backwards compatible at all. Yes, what a  
> luxury it is.

Cool.

>
>
>> Remove deprecated distance(Float[], Float[]),  
>> AbstractDistanceMeasure?
>> ----------------------------------------------------------------------
>>
>>                Key: MAHOUT-58
>>                URL: https://issues.apache.org/jira/browse/MAHOUT-58
>>            Project: Mahout
>>         Issue Type: Improvement
>>           Reporter: Sean Owen
>>
>> HI all, just looking at the deprecation warnings I am seeing when  
>> compiling. Looks like we've deprecated  
>> DistanceMeasure.distance(Float[], Float[]). Looks like it is easy  
>> to just remove this altogether, and with it,  
>> AbstractDistanceMeasure. OK to do?
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>



Re: [jira] Commented: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by Isabel Drost <ap...@isabel-drost.de>.
On Monday 26 May 2008, Jeff Eastman wrote:
> Sean Owen (JIRA) wrote:
> >     [
> > https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.p
> >lugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599871#act
> >ion_12599871 ]
> >
> > Sean Owen commented on MAHOUT-58:
> > ---------------------------------
> >
> > Grant said: "We don't really need to worry about back compatibility when
> > there is nothing to be back compatible to.  Taste is probably the only
> > thing that need worry about deprecating at this point."
> >
> > Yeah that was my view. I assume that with no public releases we can
> > freely change stuff like this. I am not bothered by the warnings really
> > just helpfully suggesting I have a changelist ready to clear this out if
> > there are no objections.
>
> +1, go for it. The deprecation was pretty obsolete anyway given that all
> of the clustering algorithms have been upgraded to use Vectors.

+1 from me as well.

-- 
A language that doesn't affect the way you think about programming isnot worth 
knowing.
  |\      _,,,---,,_       Web:   <http://www.isabel-drost.de>
  /,`.-'`'    -.  ;-;;,_
 |,4-  ) )-,_..;\ (  `'-'
'---''(_/--'  `-'\_) (fL)  IM:  <xm...@spaceboyz.net>

Re: [jira] Commented: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by Jeff Eastman <je...@windwardsolutions.com>.
Sean Owen (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599871#action_12599871 ] 
>
> Sean Owen commented on MAHOUT-58:
> ---------------------------------
>
> Grant said: "We don't really need to worry about back compatibility when there is nothing to be back compatible to.  Taste is probably the only thing that need worry about deprecating at this point."
>
> Yeah that was my view. I assume that with no public releases we can freely change stuff like this. I am not bothered by the warnings really just helpfully suggesting I have a changelist ready to clear this out if there are no objections.
>   
+1, go for it. The deprecation was pretty obsolete anyway given that all 
of the clustering algorithms have been upgraded to use Vectors.
> On Taste, erm what should be deprecated? I already took the opportunity to remove anything that was deprecated, and remove more stuff that is kind of old and unused. I consider this a "2.0" release and not necessarily backwards compatible at all. Yes, what a luxury it is.
>
>   
>> Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?
>> ----------------------------------------------------------------------
>>
>>                 Key: MAHOUT-58
>>                 URL: https://issues.apache.org/jira/browse/MAHOUT-58
>>             Project: Mahout
>>          Issue Type: Improvement
>>            Reporter: Sean Owen
>>
>> HI all, just looking at the deprecation warnings I am seeing when compiling. Looks like we've deprecated DistanceMeasure.distance(Float[], Float[]). Looks like it is easy to just remove this altogether, and with it, AbstractDistanceMeasure. OK to do?
>>     
>
>   


[jira] Commented: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599871#action_12599871 ] 

Sean Owen commented on MAHOUT-58:
---------------------------------

Grant said: "We don't really need to worry about back compatibility when there is nothing to be back compatible to.  Taste is probably the only thing that need worry about deprecating at this point."

Yeah that was my view. I assume that with no public releases we can freely change stuff like this. I am not bothered by the warnings really just helpfully suggesting I have a changelist ready to clear this out if there are no objections.

On Taste, erm what should be deprecated? I already took the opportunity to remove anything that was deprecated, and remove more stuff that is kind of old and unused. I consider this a "2.0" release and not necessarily backwards compatible at all. Yes, what a luxury it is.

> Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-58
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-58
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Sean Owen
>
> HI all, just looking at the deprecation warnings I am seeing when compiling. Looks like we've deprecated DistanceMeasure.distance(Float[], Float[]). Looks like it is easy to just remove this altogether, and with it, AbstractDistanceMeasure. OK to do?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MAHOUT-58) Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved MAHOUT-58.
-----------------------------

    Resolution: Fixed

> Remove deprecated distance(Float[], Float[]), AbstractDistanceMeasure?
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-58
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-58
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Sean Owen
>
> HI all, just looking at the deprecation warnings I am seeing when compiling. Looks like we've deprecated DistanceMeasure.distance(Float[], Float[]). Looks like it is easy to just remove this altogether, and with it, AbstractDistanceMeasure. OK to do?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.