You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "heyihong (via GitHub)" <gi...@apache.org> on 2025/09/11 17:01:59 UTC
[PR] [SPARK-53556] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
heyihong opened a new pull request, #52312:
URL: https://github.com/apache/spark/pull/52312
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3292286050
> > On second thought, the space saved by having fewer data type fields may not be worth the implementation complexity of inferring the type. It may be better to have a dedicated data type field instead.
>
> +1. Can we refactor it?
es, here is the PR: https://github.com/apache/spark/pull/52342. This change is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3290628017
> On second thought, the space saved by having fewer data type fields may not be worth the implementation complexity of inferring the type. It may be better to have a dedicated data type field instead.
+1. Can we refactor it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3285083090
> > The current implementation always sets struct data type information in protobuf messages, even when this information is redundant or not needed.
>
> I may miss some context. When is this information redundant or not needed? Do we have some examples?
Yes, for an array of structs, only the first element needs to include the type information. The rest do not need to have the type information set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3285780746
> Literal should separate the data and metadata (data type), so array of struct literal should have the array of struct value and the array of struct data type. This is how the catalyst Litetal is designed. `ArrayData` represents the data of an array and it does not contain the data type.
>
> How was the literal protobuf designed?
Having a clear separation between the data and metadata (data type) can be handled with the current literal protobuf implementation. For example, you can have an array whose elements don’t include any type information, while the dataType field holds the full type definition. The reason for mixing data and metadata here is to achieve a more compact format and save space by setting fewer data type fields (since they can be inferred).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3281937179
@zhengruifeng @hvanhovell @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong closed pull request #52312: [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter
URL: https://github.com/apache/spark/pull/52312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3284621754
> The current implementation always sets struct data type information in protobuf messages, even when this information is redundant or not needed.
I may miss some context. When is this information redundant or not needed? Do we have some examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53556][CONNECT] Avoid setting redundant struct data types in LiteralValueProtoConverter [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #52312:
URL: https://github.com/apache/spark/pull/52312#issuecomment-3285333148
Literal should separate the data and metadata (data type), so array of struct literal should have the array of struct value and the array of struct data type. This is how the catalyst Litetal is designed. `ArrayData` represents the data of an array and it does not contain the data type.
How was the litera protobuf designed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org