[jira] [Commented] (GEODE-3193) locator pid file is removed even if there was a problem while shutting down

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123651#comment-16123651 ] 

ASF subversion and git services commented on GEODE-3193:
--------------------------------------------------------

Commit 894f3ee710e500c83f06be660b852d389cbb94cb in geode's branch refs/heads/develop from [~apache@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=894f3ee ]

GEODE-3413: overhaul launcher and process classes and tests

This is primarily an overall of all ServerLauncher and LocatorLauncher
tests and org.apache.geode.internal.process tests. The main classes in
org.apachage.geode.internal.process package are also cleaned up.

In addition, several bugs involving these classes and tests are fixed.

Here is the complete list of tickets that are resolved in this overhaul:

* GEODE-1229: LocatorLauncherRemoteJUnitTest.testStartOverwritesStalePidFile
* GEODE-2791: LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError
* GEODE-1308: CI failure: LocatorLauncherTest.testSetBindAddressToNonLocalHost
* GEODE-1309: CI failure: ServerLauncherTest.testSetServerBindAddressToNonLocalHost
* GEODE-3193: locator pid file is removed even if there was a problem while shutting down
* GEODE-3413: Overhaul launcher tests and process tests
* GEODE-3414: Cleanup org.apache.geode.internal.process package

Note I moved all useful tests from LocatorLauncherAssemblyIntegrationTest
into the other launcher tests in geode-core.


> locator pid file is removed even if there was a problem while shutting down
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-3193
>                 URL: https://issues.apache.org/jira/browse/GEODE-3193
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>    Affects Versions: 1.0.0-incubating, 1.1.0, 1.1.1, 1.2.0
>            Reporter: Swapnil Bawaskar
>            Assignee: Kirk Lund
>
> The pid file should not be cleaned up if the locator process failed to shutdown with a problem like GEODE-3191.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)