You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/12 12:25:09 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #24977: Apply flake8-logging-format changes to core

potiuk commented on code in PR #24977:
URL: https://github.com/apache/airflow/pull/24977#discussion_r918905222


##########
airflow/www/fab_security/sqla/manager.py:
##########
@@ -106,7 +106,7 @@ def create_db(self):
                 log.info(c.LOGMSG_INF_SEC_ADD_DB)
             super().create_db()
         except Exception as e:
-            log.error(c.LOGMSG_ERR_SEC_CREATE_DB.format(str(e)))
+            log.error(c.LOGMSG_ERR_SEC_CREATE_DB.format(str(e)))  # noqa: G001

Review Comment:
   Should we extract a common function doing the logging.
   
   ```
   log_error(c.LOGMSG_ERR_SEC_CREATE_DB, e)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org