You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/07/11 01:25:58 UTC
Review Request 23404: Optimize for empty relation scans
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23404/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7385
https://issues.apache.org/jira/browse/HIVE-7385
Repository: hive-git
Description
-------
Optimize for empty relation scans
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9
itests/qtest/testconfiguration.properties f074b8e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 5bad2e5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyTaskDispatcher.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java cf049b2
ql/src/test/queries/clientpositive/optimize_nullscan.q PRE-CREATION
ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/23404/diff/
Testing
-------
added new tests.
Thanks,
Ashutosh Chauhan
Re: Review Request 23404: Optimize for empty relation scans
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23404/
-----------------------------------------------------------
(Updated July 18, 2014, 9:09 p.m.)
Review request for hive.
Changes
-------
Incorporated Gunther's suggestions. Also, includes optimization for limit 0 in subquery.
Bugs: HIVE-7385
https://issues.apache.org/jira/browse/HIVE-7385
Repository: hive-git
Description
-------
Optimize for empty relation scans
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 34359c1
itests/qtest/testconfiguration.properties 4e6693a
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 5bad2e5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanTaskDispatcher.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java cf049b2
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 10c8d51
ql/src/test/queries/clientpositive/optimize_nullscan.q PRE-CREATION
ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/23404/diff/
Testing
-------
added new tests.
Thanks,
Ashutosh Chauhan
Re: Review Request 23404: Optimize for empty relation scans
Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23404/#review47797
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/23404/#comment84003>
nit, space after ","
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java
<https://reviews.apache.org/r/23404/#comment84002>
can you add a condition here for limit 0? that way we handle nested limit 0 as well.
ql/src/test/queries/clientpositive/optimize_nullscan.q
<https://reviews.apache.org/r/23404/#comment84001>
can you add tests that filter after a union or join? the reason is I want to make sure we propagate to all table scans above the null filter (select * from (... union ... join) where false;
- Gunther Hagleitner
On July 10, 2014, 11:25 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23404/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 11:25 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7385
> https://issues.apache.org/jira/browse/HIVE-7385
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Optimize for empty relation scans
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9
> itests/qtest/testconfiguration.properties f074b8e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 5bad2e5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyTaskDispatcher.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java cf049b2
> ql/src/test/queries/clientpositive/optimize_nullscan.q PRE-CREATION
> ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23404/diff/
>
>
> Testing
> -------
>
> added new tests.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 23404: Optimize for empty relation scans
Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23404/#review47795
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java
<https://reviews.apache.org/r/23404/#comment83999>
i think you need to add a similar statement to TezCompiler to enable it there as well.
ql/src/test/results/clientpositive/optimize_nullscan.q.out
<https://reviews.apache.org/r/23404/#comment83998>
the explain plan doesn't actually show whether the opt kicked in or not. extended might (because it's printing the file format used.)
- Gunther Hagleitner
On July 10, 2014, 11:25 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23404/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 11:25 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7385
> https://issues.apache.org/jira/browse/HIVE-7385
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Optimize for empty relation scans
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9
> itests/qtest/testconfiguration.properties f074b8e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 5bad2e5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyTaskDispatcher.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java cf049b2
> ql/src/test/queries/clientpositive/optimize_nullscan.q PRE-CREATION
> ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23404/diff/
>
>
> Testing
> -------
>
> added new tests.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>