You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "KKcorps (via GitHub)" <gi...@apache.org> on 2023/07/27 06:21:58 UTC
[GitHub] [pinot] KKcorps opened a new pull request, #11195: Make Preload Integration test more extensible
KKcorps opened a new pull request, #11195:
URL: https://github.com/apache/pinot/pull/11195
* This will allow us to simply extend this test for more usecases
* The primary difference in most such test is what data is loaded and how to check if data is loaded or not. Hence seperating out these two methods make sense so they can be overwritten by child classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps commented on a diff in pull request #11195: Make Preload Integration test more extensible
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps commented on code in PR #11195:
URL: https://github.com/apache/pinot/pull/11195#discussion_r1277668775
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/UpsertTableSegmentPreloadIntegrationTest.java:
##########
@@ -211,7 +226,7 @@ public void testSegmentAssignment()
serverStarter.getConfig().getProperty(CommonConstants.Server.CONFIG_OF_INSTANCE_DATA_DIR);
File[] files = new File(segmentDir, getTableName() + "_REALTIME").listFiles();
for (File file : files) {
- if (file.getName().contains("tmp") || file.getName().contains("consumer")) {
+ if (!file.getName().startsWith(getTableName())) {
Review Comment:
aah, basically apart from the segment directories, pinot also creates multiple other directories. I simply wanted to exclude them as they don't contain immutable segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps merged pull request #11195: Make Preload Integration test more extensible
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps merged PR #11195:
URL: https://github.com/apache/pinot/pull/11195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11195: Make Preload Integration test more extensible
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11195:
URL: https://github.com/apache/pinot/pull/11195#issuecomment-1653018230
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11195?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11195](https://app.codecov.io/gh/apache/pinot/pull/11195?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (386e551) into [master](https://app.codecov.io/gh/apache/pinot/commit/d9c64f347af0d1c6e27c8b0c304033be9f463f69?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d9c64f3) will **increase** coverage by `0.00%`.
> Report is 8 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11195 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2214 2168 -46
Lines 118822 116719 -2103
Branches 17978 17743 -235
=========================================
Hits 137 137
+ Misses 118665 116562 -2103
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `0.11% <ø> (-0.01%)` | :arrow_down: |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 153 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11195/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11195: Make Preload Integration test more extensible
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11195:
URL: https://github.com/apache/pinot/pull/11195#discussion_r1276635909
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/UpsertTableSegmentPreloadIntegrationTest.java:
##########
@@ -211,7 +226,7 @@ public void testSegmentAssignment()
serverStarter.getConfig().getProperty(CommonConstants.Server.CONFIG_OF_INSTANCE_DATA_DIR);
File[] files = new File(segmentDir, getTableName() + "_REALTIME").listFiles();
for (File file : files) {
- if (file.getName().contains("tmp") || file.getName().contains("consumer")) {
+ if (!file.getName().startsWith(getTableName())) {
Review Comment:
not sure i understand what this change means. maybe add a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org