You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "paul-rogers (via GitHub)" <gi...@apache.org> on 2023/04/04 19:06:53 UTC

[GitHub] [druid] paul-rogers opened a new pull request, #14024: gRPC query extension

paul-rogers opened a new pull request, #14024:
URL: https://github.com/apache/druid/pull/14024

   Implementation of a gRPC query endpoint per issue #13469.
   
   Provides a single gRPC-based endpoint for SQL queries. The query request is similar to the existing REST `SqlQuery` class. The response is gRPC-specific. It provides the result schema along with the results as a binary "blob". Results can be in CSV, JSON array lines or as an array of Protobuf objects. If using Protobuf, the corresponding class must be installed along with the rRPC query extension so it is available to the Broker at runtime.
   
   The PR includes both unit and integration tests. The PR includes additional files that are also offered in other PRs. The intent is that those other PRs ([#13877](https://github.com/apache/druid/pull/13877) and [#14009](https://github.com/apache/druid/pull/14009)) are merged first, then this one merges with master so that the other files "disappear" from this PR.
   
   This PR also has a number of code-cleanup changes encountered while doing the implementation.
   
   See the `README.md` file in the PR for details. See the [`query.proto`](https://github.com/apache/druid/compare/master...paul-rogers:druid:grpc-query?expand=1#diff-64b5e59c67151a4b864bf0a34f31c66a53c3612a888ef974dce28c478d444279) file for the gRPC protocol and Protobuf messages.
   
   he project consists of three Maven modules:
   
   * `grpc-query`: The actual gRPC query endpoint.
   * `grpc-query-it`: Integration tests for the extension.
   * `grpc-shaded`: Creates a shaded jar containing gRPC and our rRPC service definition.
   
   The shaded module is needed because gRPC uses a version of Guava different than that which Druid uses. We get runtime errors if we try to combine the two. The shaded module contains the service definition because that generates code that also uses Guava.
   
   The IT module has to be separate because it has dependencies that occur in the Maven build after the gRPC module. Specifically, it depends on it-cases which must come after distribution, but grpc-query must come before distribution.
   
   
   
   #### Release note
   
   This is a "contrib" extension. We don't seem to document such extensions in Druid itself. The `README.md` can serve as documentation instead.
   
   <hr>
   
   This PR has:
   
   - [X] been self-reviewed.
   - [X] added documentation for new or modified features or behaviors.
   - [X] a release note entry in the PR description.
   - [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [X] added integration tests.
   - [X] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] gRPC query extension (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14024: gRPC query extension
URL: https://github.com/apache/druid/pull/14024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] gRPC query extension (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14024:
URL: https://github.com/apache/druid/pull/14024#issuecomment-1987427870

   This pull request/issue has been closed due to lack of activity. If you think that
   is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] paul-rogers commented on pull request #14024: gRPC query extension

Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on PR #14024:
URL: https://github.com/apache/druid/pull/14024#issuecomment-1500724237

   The build is failing due to `dependency:analyze` being unable to find the grpc symbols. This may be due to the shaded grpc jar being unavailable. It may be unavailable because it is not in the saved Maven cache, and this particular Maven invocation did not rebuild it. A similar problem was resolved by moving from the `compile` to `install` Maven step.
   
   Per the [documentation](https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html):
   
   > Invokes the execution of the [lifecycle phase](http://maven.apache.org/ref/current/maven-core/lifecycles.html) `test-compile` prior to executing itself.
   
   This step does a compilation, but does not trigger creation of the shaded jar, which then causes compile errors.
   
   I've tried adding `install` to the `analyze_dependencies_script.sh` script.
   
   At this point, I won't be available to continue the fixes. Can someone else please continue chipping away at the various build issues? It seems the shaded jar does not play well with our build scripts: I've made several changes to work around the issue: more may be needed. Or, perhaps we're doing something wrong with the shaded jar. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] gRPC query extension (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14024:
URL: https://github.com/apache/druid/pull/14024#issuecomment-1937366143

   This pull request has been marked as stale due to 60 days of inactivity.
   It will be closed in 4 weeks if no further activity occurs. If you think
   that's incorrect or this pull request should instead be reviewed, please simply
   write any comment. Even if closed, you can still revive the PR at any time or
   discuss it on the dev@druid.apache.org list.
   Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org