You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/27 17:29:41 UTC
[GitHub] [spark] ueshin commented on a diff in pull request #37305: [SPARK-39881][PS] Fix erroneous check for black and reenable black validation.
ueshin commented on code in PR #37305:
URL: https://github.com/apache/spark/pull/37305#discussion_r931324496
##########
python/pyspark/ml/feature.py:
##########
@@ -968,7 +968,7 @@ class _CountVectorizerParams(JavaParams, HasInputCol, HasOutputCol):
def __init__(self, *args: Any):
super(_CountVectorizerParams, self).__init__(*args)
- self._setDefault(minTF=1.0, minDF=1.0, maxDF=2 ** 63 - 1, vocabSize=1 << 18, binary=False)
+ self._setDefault(minTF=1.0, minDF=1.0, maxDF=2**63 - 1, vocabSize=1 << 18, binary=False)
Review Comment:
Is this style change because we are upgrading `black`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org