You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by nikpawar89 <gi...@git.apache.org> on 2016/11/03 08:26:08 UTC

[GitHub] incubator-fineract pull request #232: sql fix

GitHub user nikpawar89 opened a pull request:

    https://github.com/apache/incubator-fineract/pull/232

    sql fix

    Minor fix for sql

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nikpawar89/incubator-fineract addressModuleFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #232
    
----
commit 4a0c98d6f37bbd92aea5375cd8f76e489b6431b9
Author: nikpawar89 <ni...@yahoo.in>
Date:   2016-11-03T08:23:17Z

    sql fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #232: sql fix

Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 closed the pull request at:

    https://github.com/apache/incubator-fineract/pull/232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #232: sql fix

Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/232#discussion_r86332152
  
    --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V316__address_module_tables_metadat.sql ---
    @@ -20,7 +20,7 @@
     
     
     -- code inserts
    -INSERT INTO `m_code` (`code_name`, `is_system_defined`) VALUES ('STATE',1);
    +INSERT INTO `m_code` (`code_name`, `is_system_defined`) VALUES ('STATES',1);
    --- End diff --
    
    You need to add new migration to alter column name. This migration file is already deployed on servers, so it won't have any effect 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---