You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/01 13:12:16 UTC

[GitHub] Myasuka commented on a change in pull request #7639: [FLINK-9920] Only check part files in BucketingSinkFaultToleranceITCase

Myasuka commented on a change in pull request #7639: [FLINK-9920] Only check part files in BucketingSinkFaultToleranceITCase
URL: https://github.com/apache/flink/pull/7639#discussion_r253042777
 
 

 ##########
 File path: flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFaultToleranceITCase.java
 ##########
 @@ -144,6 +148,10 @@ public void postSubmit() throws Exception {
 
 		while (files.hasNext()) {
 			LocatedFileStatus file = files.next();
+//			if (!file.getPath().getName().startsWith(PART_PREFIX)) {
+				// ignore files that don't match with our expected part prefix
+//				continue;
+//			}
 
 Review comment:
   commented code should be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services