[jira] [Commented] (TS-3066) Latest master does not compile on OmniOS

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126234#comment-14126234 ] 

Leif Hedstrom commented on TS-3066:
-----------------------------------

I think a fix like this would be the appropriate solution (although I'm still not sure what we did to break this between 5.0 -> 5.1):

{code}
diff --git a/lib/ts/ink_resolver.h b/lib/ts/ink_resolver.h
index 1532c40..b0373ba 100644
--- a/lib/ts/ink_resolver.h
+++ b/lib/ts/ink_resolver.h
@@ -200,8 +200,8 @@ parse_host_res_preference(
 #ifndef NS_GET16
 #define NS_GET16(s, cp) do { \
         const u_char *t_cp = (const u_char *)(cp); \
-        (s) = ((u_int16_t)t_cp[0] << 8) \
-            | ((u_int16_t)t_cp[1]) \
+        (s) = ((uint16_t)t_cp[0] << 8) \
+            | ((uint16_t)t_cp[1]) \
             ; \
         (cp) += NS_INT16SZ; \
 } while (0)
@@ -221,7 +221,7 @@ parse_host_res_preference(
 
 #ifndef NS_PUT16
 #define NS_PUT16(s, cp) do { \
-        u_int16_t t_s = (u_int16_t)(s); \
+        uint16_t t_s = (uint16_t)(s); \
         u_char *t_cp = (u_char *)(cp); \
         *t_cp++ = t_s >> 8; \
         *t_cp   = t_s; \
@@ -269,7 +269,7 @@ struct ts_imp_res_state {
   int     _vcsock;                /*%< PRIVATE: for res_send VC i/o */
   u_int   _flags;                 /*%< PRIVATE: see below */
   u_int   _pad;                   /*%< make _u 64 bit aligned */
-  u_int16_t              _nstimes[INK_MAXNS]; /*%< ms. */
+  uint16_t              _nstimes[INK_MAXNS]; /*%< ms. */
 };
 typedef ts_imp_res_state *ink_res_state;
 {code}


> Latest master does not compile on OmniOS
> ----------------------------------------
>
>                 Key: TS-3066
>                 URL: https://issues.apache.org/jira/browse/TS-3066
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Core
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 5.2.0
>
>
> We introduced (removed?) something between 5.0 and 5.1, where we now fail on OmniOS with
> {code}
> In file included from ../../lib/ts/libts.h:66:0,
>                  from P_EventSystem.h:34,
>                  from EventSystem.cc:31:
> ../../lib/ts/ink_resolver.h:272:3: error: ‘u_int16_t’ does not name a type
>    u_int16_t              _nstimes[INK_MAXNS]; /*%< ms. */
>    ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)