You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/11/07 13:27:33 UTC
Review Request 63616: Log Search UI: button with caret doesn't toggle
dropdown is some cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63616/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-22374
https://issues.apache.org/jira/browse/AMBARI-22374
Repository: ambari
Description
-------
If user clicks in the gap between icon and caret, dropdown isn't toggled.
Diffs
-----
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.html ca70927
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less 615db24
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts 0aa7c7e
Diff: https://reviews.apache.org/r/63616/diff/1/
Testing
-------
Executed 109 of 109 SUCCESS (3.186 secs / 3.147 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 63616: Log Search UI: button with caret doesn't
toggle dropdown is some cases
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63616/#review190297
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Nov. 7, 2017, 1:27 p.m., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63616/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 1:27 p.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-22374
> https://issues.apache.org/jira/browse/AMBARI-22374
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If user clicks in the gap between icon and caret, dropdown isn't toggled.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.html ca70927
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less 615db24
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts 0aa7c7e
>
>
> Diff: https://reviews.apache.org/r/63616/diff/1/
>
>
> Testing
> -------
>
> Executed 109 of 109 SUCCESS (3.186 secs / 3.147 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>