[GitHub] [pulsar-client-go] merlimat opened a new pull request #300: Fixed pooled buffer lifecycle

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #300:
URL: https://github.com/apache/pulsar-client-go/pull/300


   ### Motivation
   
   The buffer pooling introduced in #292 has a serious bug in that the buffer gets released back to the pool after it's written on the connection. The problem is that, if there's a failure, a message can be written again after the reconnection, in which case we're sending garbage data. 
   
   We need to tie the buffer lifecycle of the send request instead and, in that optic, it doesn't make to have the pool on the connection, rather it should be at the partition producer level.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat merged pull request #300: Fixed pooled buffer lifecycle

[GitBox <gi...@apache.org>]

merlimat merged pull request #300:
URL: https://github.com/apache/pulsar-client-go/pull/300


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org