You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/01 08:51:10 UTC
[GitHub] [pinot] richardstartin commented on a change in pull request #7820: push JSON Path evaluation down to storage layer
richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759970147
##########
File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonPathQueriesTest.java
##########
@@ -55,17 +60,37 @@
private static final String LONG_COLUMN = "longColumn";
private static final String STRING_COLUMN = "stringColumn";
private static final String JSON_COLUMN = "jsonColumn";
+ private static final String RAW_JSON_COLUMN = "rawJsonColumn";
+ private static final String RAW_BYTES_COLUMN = "rawBytesColumn";
+ private static final String DICTIONARY_BYTES_COLUMN = "dictionaryBytesColumn";
+ private static final String RAW_STRING_COLUMN = "rawStringColumn";
+ private static final String DICTIONARY_STRING_COLUMN = "dictionaryStringColumn";
private static final String JSON_COLUMN_WITHOUT_INDEX = "jsonColumnWithoutIndex";
private static final Schema SCHEMA = new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension(INT_COLUMN, FieldSpec.DataType.INT)
.addSingleValueDimension(LONG_COLUMN, FieldSpec.DataType.LONG)
.addSingleValueDimension(STRING_COLUMN, FieldSpec.DataType.STRING)
.addSingleValueDimension(JSON_COLUMN, FieldSpec.DataType.JSON)
+ .addSingleValueDimension(RAW_JSON_COLUMN, FieldSpec.DataType.JSON)
+ .addSingleValueDimension(RAW_BYTES_COLUMN, FieldSpec.DataType.BYTES)
Review comment:
I added these because I think the test setup is very good, it can actually be used to test cases on `jsonextractscalar` that weren't previously tested, and these columns are only used to test `jsonextractscalar`. Indeed, JSON literals did not work and still do not work with `BYTES` and `STRING` Does this alleviate your concern?
##########
File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonPathQueriesTest.java
##########
@@ -55,17 +60,37 @@
private static final String LONG_COLUMN = "longColumn";
private static final String STRING_COLUMN = "stringColumn";
private static final String JSON_COLUMN = "jsonColumn";
+ private static final String RAW_JSON_COLUMN = "rawJsonColumn";
+ private static final String RAW_BYTES_COLUMN = "rawBytesColumn";
+ private static final String DICTIONARY_BYTES_COLUMN = "dictionaryBytesColumn";
+ private static final String RAW_STRING_COLUMN = "rawStringColumn";
+ private static final String DICTIONARY_STRING_COLUMN = "dictionaryStringColumn";
private static final String JSON_COLUMN_WITHOUT_INDEX = "jsonColumnWithoutIndex";
private static final Schema SCHEMA = new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension(INT_COLUMN, FieldSpec.DataType.INT)
.addSingleValueDimension(LONG_COLUMN, FieldSpec.DataType.LONG)
.addSingleValueDimension(STRING_COLUMN, FieldSpec.DataType.STRING)
.addSingleValueDimension(JSON_COLUMN, FieldSpec.DataType.JSON)
+ .addSingleValueDimension(RAW_JSON_COLUMN, FieldSpec.DataType.JSON)
+ .addSingleValueDimension(RAW_BYTES_COLUMN, FieldSpec.DataType.BYTES)
Review comment:
I added these because I think the test setup is very good, it can actually be used to test cases on `jsonextractscalar` that weren't previously tested, and these columns are only used to test `jsonextractscalar`. Indeed, JSON literals did not work and still do not work with `BYTES` and `STRING`.
Does this alleviate your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org