You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/10/11 23:55:23 UTC
[GitHub] [trafficserver] meeramn opened a new pull request #8408: Doc: fix typos in Strategy documentation
meeramn opened a new pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408
Fix typo in configuration **scheme** and update documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#issuecomment-942596962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#issuecomment-963670752
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#discussion_r726666298
##########
File path: doc/admin-guide/files/strategies.yaml.en.rst
##########
@@ -178,13 +178,14 @@ Each **strategy** in the list may using the following parameters::
#. **cache_key**: Uses the hash key from the **cachekey** plugin. defaults to **path** if the **cachekey** plugin is not configured on the **remap**.
#. **url**: Creates a hash from the entire request url.
-- **go_direct** - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
+- **go_direct**: - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
Review comment:
Thanks for making these consistent with the colon. Making them each have a colon (like you're doing here) makes sense to me.
Might as well also remove the hyphen for those items that have it as well. Doesn't make much sense to have a colon and a hyphen for some of them. (Looks like `go_direct` and `cache_peer_result` each have a hyphen.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] meeramn commented on a change in pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
meeramn commented on a change in pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#discussion_r727484811
##########
File path: doc/admin-guide/files/strategies.yaml.en.rst
##########
@@ -178,13 +178,14 @@ Each **strategy** in the list may using the following parameters::
#. **cache_key**: Uses the hash key from the **cachekey** plugin. defaults to **path** if the **cachekey** plugin is not configured on the **remap**.
#. **url**: Creates a hash from the entire request url.
-- **go_direct** - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
+- **go_direct**: - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
Review comment:
Good observation. Removed hyphens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall removed a comment on pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
bryancall removed a comment on pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#issuecomment-942596962
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on a change in pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#discussion_r727228332
##########
File path: doc/admin-guide/files/strategies.yaml.en.rst
##########
@@ -178,13 +178,14 @@ Each **strategy** in the list may using the following parameters::
#. **cache_key**: Uses the hash key from the **cachekey** plugin. defaults to **path** if the **cachekey** plugin is not configured on the **remap**.
#. **url**: Creates a hash from the entire request url.
-- **go_direct** - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
+- **go_direct**: - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
Review comment:
+1 on @bneradt say's otherwise it looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] meeramn commented on a change in pull request #8408: Doc: fix typos in Strategy documentation
Posted by GitBox <gi...@apache.org>.
meeramn commented on a change in pull request #8408:
URL: https://github.com/apache/trafficserver/pull/8408#discussion_r727484811
##########
File path: doc/admin-guide/files/strategies.yaml.en.rst
##########
@@ -178,13 +178,14 @@ Each **strategy** in the list may using the following parameters::
#. **cache_key**: Uses the hash key from the **cachekey** plugin. defaults to **path** if the **cachekey** plugin is not configured on the **remap**.
#. **url**: Creates a hash from the entire request url.
-- **go_direct** - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
+- **go_direct**: - A boolean value indicating whether a transaction may bypass proxies and go direct to the origin. Defaults to **true**
Review comment:
Good observation. Removed hyphens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org