You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/06 17:37:04 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8774:
Re-enable pylint for common, connector, and test files
codecov-io edited a comment on issue #8774: Re-enable pylint for common, connector, and test files
URL: https://github.com/apache/incubator-superset/pull/8774#issuecomment-562381967
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=h1) Report
> Merging [#8774](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/665e94784ca75257df6fe1455e5cdfc41e8c5e46?src=pr&el=desc) will **decrease** coverage by `6.23%`.
> The diff coverage is `13.95%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8774/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8774 +/- ##
==========================================
- Coverage 72.07% 65.83% -6.24%
==========================================
Files 123 482 +359
Lines 12844 24155 +11311
Branches 0 2770 +2770
==========================================
+ Hits 9257 15903 +6646
- Misses 3587 8074 +4487
- Partials 0 178 +178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `37.19% <0%> (ø)` | :arrow_up: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.66% <100%> (ø)` | :arrow_up: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.38% <37.5%> (ø)` | :arrow_up: |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <50%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.46% <0%> (ø)` | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | |
| [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `80.28% <0%> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4) | `76.92% <0%> (ø)` | |
| [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `38.46% <0%> (ø)` | |
| ... and [353 more](https://codecov.io/gh/apache/incubator-superset/pull/8774/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=footer). Last update [665e947...9b80348](https://codecov.io/gh/apache/incubator-superset/pull/8774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org