[GitHub] [commons-collections] kinow commented on a change in pull request #120: [COLLECTIONS-737] The test FluentIterableTest.size should be splitted

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #120: [COLLECTIONS-737] The test FluentIterableTest.size should be splitted
URL: https://github.com/apache/commons-collections/pull/120#discussion_r364592914
 
 

 ##########
 File path: src/test/java/org/apache/commons/collections4/FluentIterableTest.java
 ##########
 @@ -416,12 +416,6 @@ public void isEmpty() {
 
     @Test
     public void size() {
-        try {
-            FluentIterable.of((Iterable<?>) null).size();
-            fail("expecting NullPointerException");
-        } catch (final NullPointerException npe) {
-            // expected
-        }
 
 Review comment:
   This test was covering the case of `FluentIterable.of(null)`, but there are other tests covering it too. And as pointed by the OP, this method was - according to its name - supposed to test the `.size()` method. :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services