You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2017/02/22 15:17:44 UTC
[jira] [Commented] (THRIFT-4102) TBufferedTransport performance
issue since 0.10.0
[ https://issues.apache.org/jira/browse/THRIFT-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878447#comment-15878447 ]
James E. King, III commented on THRIFT-4102:
--------------------------------------------
If you are able to submit a pull request removing that line, the build jobs will confirm whether it is needed through the cross test.
See: https://thrift.apache.org/docs/HowToContribute for more information on how to do this. Thanks!
> TBufferedTransport performance issue since 0.10.0
> -------------------------------------------------
>
> Key: THRIFT-4102
> URL: https://issues.apache.org/jira/browse/THRIFT-4102
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.10.0
> Reporter: Jin Yao
>
> I upgrade thrift from 0.9.3 to 0.10.0, and our rpc calls slow down.
> I digged around the code, and find maybe it caused by the write function in TBufferedTransport.
> The last line seems useless, but cost time.
> {code:title=TTransport.py|borderStyle=solid}
> def write(self, buf):
> try:
> self.__wbuf.write(buf)
> except Exception as e:
> # on exception reset wbuf so it doesn't contain a partial function call
> self.__wbuf = BufferIO()
> raise e
> self.__wbuf.getvalue() # it seems useless, but cost time
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)