[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts
URL: https://github.com/apache/airflow/pull/6266#discussion_r331936604
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -233,7 +206,7 @@ ENV AIRFLOW_BRANCH=${AIRFLOW_BRANCH}
 ENV AIRFLOW_GITHUB_DOWNLOAD=https://raw.githubusercontent.com/${AIRFLOW_REPO}/${AIRFLOW_BRANCH}
 
 # Airflow Extras installed
-ARG AIRFLOW_EXTRAS="all"
+ARG AIRFLOW_EXTRAS="all,stastd,elasticsearch"
 
 Review comment:
   The statsd is not, elasticsearch is.  
   
   I am not sure we have an understanding about what different extras mean actually. When you look at setup.py currently we have: **devel_ci** = **devel_all** = **all** (except in PY3 devel_ci does not contain snakebite).
   
   We also have:
   * **devel_minreq** (devel + kubernetes + mysql + doc + password + cgroups)
   * **devel_hadoop** (devel_minreq + hive + hdfs + webhdfs + kerberos and devel_hadoop).
   
   So we might use the opportunity to clean it up !
   
   My proposal is only to leave *devel* and *all* and make sure *all* does not contain devel. Then for CI we would have [all,devel] extras and for Prod images only [all].
   
   We can also leave *devel_minreq* and *devel_hadoop* as they are good for those casese.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services