You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "KP (JIRA)" <ji...@codehaus.org> on 2010/10/12 20:12:34 UTC
[jira] Issue Comment Edited: (MASSEMBLY-510) leading period ('.')
added to directory names
[ http://jira.codehaus.org/browse/MASSEMBLY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239319#action_239319 ]
KP edited comment on MASSEMBLY-510 at 10/12/10 1:11 PM:
--------------------------------------------------------
I think I found the issue. In {{AssemblyFormatUtils.java}}, around line 263:
{code}
value = StringUtils.replace( value, "./", "" );
{code}
This means that file sets in the assembly descriptor that the '../' entry will break.
The quick workaround is to use {{..\\\\}} instead, as this will not trigger the calls to {{StringUtils.replace()}}.
I will create a unit test for this when I get the chance.
was (Author: thealchemist):
I think I found the issue. In {{AssemblyFormatUtils.java}}, around line 263:
{code}
value = StringUtils.replace( value, "./", "" );
{code}
This means that file sets in the assembly descriptor that the '../' entry will break.
The quick workaround is to use '..\\\\' instead, as this will not trigger the calls to {{StringUtils.replace()}}.
I will create a unit test for this when I get the chance.
> leading period ('.') added to directory names
> ---------------------------------------------
>
> Key: MASSEMBLY-510
> URL: http://jira.codehaus.org/browse/MASSEMBLY-510
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Environment: Windows XP, SP3
> Maven 2.2.1
> Maven Assembly 2.2
> Reporter: KP
> Attachments: dist.xml, pom.xml
>
>
> $ cat dist.xml
> <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
> <id>dist</id>
> <formats>
> <format>zip</format>
> </formats>
>
>
> <fileSets>
> <fileSet>
> <directory>${project.basedir}/../paper</directory>
> </fileSet>
> <fileSet>
> <directory>${project.basedir}/../boots</directory>
> </fileSet>
> </fileSets>
>
> </assembly>
> $ mvn clean assembly:assembly
> [INFO] Scanning for projects...
> [INFO] ------------------------------------------------------------------------
> [INFO] Building oracle-sql-assembly
> [INFO] task-segment: [clean]
> [INFO] ------------------------------------------------------------------------
> [INFO] [clean:clean {execution: default-clean}]
> [INFO] Deleting directory F:\test-assembly\target
> [INFO] ------------------------------------------------------------------------
> [INFO] Building oracle-sql-assembly
> [INFO] task-segment: [assembly:assembly] (aggregator-style)
> [INFO] ------------------------------------------------------------------------
> [INFO] Preparing assembly:assembly
> [INFO] ------------------------------------------------------------------------
> [INFO] Building oracle-sql-assembly
> [INFO] ------------------------------------------------------------------------
> [INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
> [INFO] [assembly:assembly {execution: default-cli}]
> [INFO] Reading assembly descriptor: src/main/assembly/dist.xml
> [INFO] Building zip: F:\test-assembly\target\test-assembly-3.1-SNAPSHOT-dist.zip
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESSFUL
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Mon Oct 11 15:34:37 EDT 2010
> [INFO] Final Memory: 18M/45M
> [INFO] ------------------------------------------------------------------------
> $ unzip -l target/test-assembly-dist.zip
> Archive: target/test-assembly-dist.zip
> Length Date Time Name
> --------- ---------- ----- ----
> 0 10-11-2010 15:34 test-assembly/
> 0 10-11-2010 15:27 test-assembly/.paper/
> 0 10-11-2010 15:27 test-assembly/.paper/random.txt
> 0 10-11-2010 15:27 test-assembly/.boots/
> 0 10-11-2010 15:27 test-assembly/.boots/boots.txt
> --------- -------
> 0 5 files
> Do you notice the '.paper' and '.boots' directories? It should just be 'paper' and 'boots', if I'm understanding it correctly.
> I tried other versions of the plugin (e.g., beta-4), I tried removing "${project.basedir}/".
> No go. :(
> P.S. If someone points me in the right direction, like a class name, I'll write a test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira