You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zoltan Haindrich <ki...@rxd.hu> on 2018/03/05 13:32:35 UTC

Review Request 65904: HIVE-17478 Move filesystem stats collection from metastore to ql

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65904/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-17478
    https://issues.apache.org/jira/browse/HIVE-17478


Repository: hive-git


Description
-------

* moves filesystem level stats collection from metastore to ql
* I think its become more obvious how, when and why this is done...
* patch 1 on reviewboard(02 on jira): is the "real change" which disarms the metastore side collector; and enables the same from ql
* patch 2 on reviewboard(03 on jira): includes an additional cleanup refactor to address the myriad of fixme-s the first phase have created


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java f99178dbc76ff72234dcf95f3cab6858c9559de9 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java baa90705d47963dfd976812abd75d5382d6bb369 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java e3934240e8b384e301bd4390029a44b7ffe2b36a 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java 946c3007504d4ab6c7ec9241183efa44be48def3 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 1d7660e8b2655a91d159b2c983bd4937d72f7464 
  ql/src/test/queries/clientpositive/explainanalyze_5.q 696064c874746b259dffd900991f9a2a23876493 
  ql/src/test/results/clientpositive/alter_table_stats_status.q.out 7ca949d437c9ef0518ace5ebaba05e91b3b78b52 
  ql/src/test/results/clientpositive/autoColumnStats_4.q.out fea8acbb267805e701b134577d07913b4a24e70c 
  ql/src/test/results/clientpositive/create_table_like_stats.q.out f88c50cfeb84183156f03942bcf79411364ba853 
  ql/src/test/results/clientpositive/default_file_format.q.out 9eb7d2d4b88d3dc5db6333317d2021297468260d 
  ql/src/test/results/clientpositive/describe_syntax.q.out a0c6182c3f8becdebb5c51466596228280b9f0b0 
  ql/src/test/results/clientpositive/partition_coltype_literals.q.out adabbb2e1003255dd5369c0d2bd8081bd25fa823 
  ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out 7f18f2b42b646d73a715e20cb2ed689fd62e6e69 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 59190893e62bd8aa672d7f7e571da55ff295be7d 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 89354a2d34249903a9ff13c4ed913a68de93057e 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ac71d0882f985a2b475eb197a4852cc943a96a1f 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java 20c10607bb46efae33a0211ee546d13c3be07401 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java 9f822564bdfdce16a262638d006b8e0c714405e9 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 50f873a013a9aa3cea0a2af8146484b9387c08f2 


Diff: https://reviews.apache.org/r/65904/diff/1/


Testing
-------


Thanks,

Zoltan Haindrich